Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-12-05 17:18:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

base: Wavyzz:phpstan-baseline
Branches Tags
Wavyzz:develop Wavyzz:22.0 Wavyzz:21.0 Wavyzz:20.0 Wavyzz:19.0 Wavyzz:18.0 Wavyzz:17.0 Wavyzz:phpstan-baseline Wavyzz:16.0 Wavyzz:15.0 Wavyzz:14.0 Wavyzz:hregis-fix_dev_mysql_workbench Wavyzz:6.0 Wavyzz:snyk-fix-3e1e5b476824b5bd60a178613c9f4541 Wavyzz:13.0 Wavyzz:12.0 Wavyzz:11.0 Wavyzz:10.0 Wavyzz:9.0 Wavyzz:gh-pages Wavyzz:8.0 Wavyzz:7.0 Wavyzz:3.7 Wavyzz:5.0 Wavyzz:3.6 Wavyzz:4.0 Wavyzz:3.9 Wavyzz:3.8 Wavyzz:3.5 Wavyzz:3.4 Wavyzz:3.3 Wavyzz:3.2 Wavyzz:3.1 Wavyzz:3.0 Wavyzz:2.9 Wavyzz:2.8
Wavyzz:22.0.3 Wavyzz:22.0.2 Wavyzz:18.0.8 Wavyzz:22.0.1 Wavyzz:21.0.4 Wavyzz:21.0.3 Wavyzz:22.0.0 Wavyzz:21.0.2 Wavyzz:18.0.7 Wavyzz:21.0.1 Wavyzz:21.0.0 Wavyzz:20.0.4 Wavyzz:20.0.3 Wavyzz:20.0.2 Wavyzz:19.0.4 Wavyzz:18.0.6 Wavyzz:20.0.1 Wavyzz:20.0.0 Wavyzz:19.0.3 Wavyzz:19.0.2 Wavyzz:19.0.1 Wavyzz:19.0.0 Wavyzz:18.0.5 Wavyzz:17.0.4 Wavyzz:18.0.4 Wavyzz:18.0.3 Wavyzz:18.0.2 Wavyzz:18.0.1 Wavyzz:18.0.0 Wavyzz:17.0.3 Wavyzz:17.0.2 Wavyzz:17.0.1 Wavyzz:16.0.5 Wavyzz:17.0.0 Wavyzz:16.0.4 Wavyzz:16.0.3 Wavyzz:16.0.2 Wavyzz:16.0.1 Wavyzz:16.0.0 Wavyzz:15.0.3 Wavyzz:15.0.2 Wavyzz:15.0.1 Wavyzz:15.0.0 Wavyzz:14.0.5 Wavyzz:14.0.4 Wavyzz:14.0.3 Wavyzz:13.0.5 Wavyzz:14.0.2 Wavyzz:14.0.1 Wavyzz:14.0.0 Wavyzz:13.0.4 Wavyzz:13.0.3 Wavyzz:13.0.2 Wavyzz:13.0.1 Wavyzz:12.0.5 Wavyzz:13.0.0 Wavyzz:12.0.4 Wavyzz:12.0.3 Wavyzz:12.0.2 Wavyzz:12.0.1 Wavyzz:11.0.5 Wavyzz:12.0.0 Wavyzz:11.0.4 Wavyzz:10.0.7 Wavyzz:11.0.3 Wavyzz:11.0.2 Wavyzz:11.0.1 Wavyzz:11.0.0 Wavyzz:10.0.6 Wavyzz:10.0.5 Wavyzz:10.0.4 Wavyzz:10.0.3 Wavyzz:10.0.2 Wavyzz:10.0.1 Wavyzz:10.0.0 Wavyzz:9.0.4 Wavyzz:8.0.6 Wavyzz:8.0.5 Wavyzz:9.0.3 Wavyzz:9.0.2 Wavyzz:9.0.1 Wavyzz:9.0.0 Wavyzz:7.0.5 Wavyzz:8.0.4 Wavyzz:8.0.3 Wavyzz:7.0.4 Wavyzz:6.0.8 Wavyzz:8.0.2 Wavyzz:8.0.1 Wavyzz:8.0.0 Wavyzz:7.0.3 Wavyzz:7.0.2 Wavyzz:6.0.7 Wavyzz:7.0.1 Wavyzz:6.0.6 Wavyzz:7.0.0 Wavyzz:6.0.5 Wavyzz:6.0.4 Wavyzz:6.0.3 Wavyzz:5.0.7 Wavyzz:6.0.2 Wavyzz:6.0.1 Wavyzz:5.0.6 Wavyzz:6.0.0 Wavyzz:5.0.5 Wavyzz:6.0.0-rc Wavyzz:5.0.4 Wavyzz:6.0.0-beta Wavyzz:5.0.3 Wavyzz:4.0.6 Wavyzz:5.0.2 Wavyzz:5.0.1 Wavyzz:4.0.5 Wavyzz:5.0.0 Wavyzz:4.0.4 Wavyzz:5.0.0-rc2 Wavyzz:5.0.0-rc1 Wavyzz:4.0.3 Wavyzz:3.9.4 Wavyzz:5.0.0-beta Wavyzz:4.0.2 Wavyzz:4.0.1 Wavyzz:4.0.0 Wavyzz:4.0.0-rc2 Wavyzz:3.9.3 Wavyzz:4.0.0-rc Wavyzz:4.0.0-beta Wavyzz:3.9.2 Wavyzz:3.9.1 Wavyzz:3.9.0 Wavyzz:3.8.4 Wavyzz:3.7.4 Wavyzz:3.9.0-rc2 Wavyzz:3.9.0-rc Wavyzz:3.5.8 Wavyzz:3.8.3 Wavyzz:3.7.3 Wavyzz:3.6.6 Wavyzz:3.6.5 Wavyzz:3.7.2 Wavyzz:3.8.2 Wavyzz:3.8.1 Wavyzz:3.8.0 Wavyzz:3.8.0-beta Wavyzz:3.8.beta1_20150712 Wavyzz:3.7.1 Wavyzz:3.6.4 Wavyzz:3.5.7 Wavyzz:3.7.0 Wavyzz:3.6.3 Wavyzz:3.6.2 Wavyzz:3.5.6 Wavyzz:3.7.beta1_20141116 Wavyzz:3.6.1 Wavyzz:3.5.5 Wavyzz:3.6.0 Wavyzz:3.5.4 Wavyzz:3.6.0-beta Wavyzz:3.5.3 Wavyzz:3.6.beta2_20140524 Wavyzz:3.6.beta1_20140514 Wavyzz:3.5.2 Wavyzz:3.6.0-alpha Wavyzz:3.5.1 Wavyzz:3.5.0 Wavyzz:3.4.2 Wavyzz:3.5.beta1_20131120 Wavyzz:3.5.beta1_20131106 Wavyzz:3.4.1 Wavyzz:3.4.0 Wavyzz:3.3.3 Wavyzz:3.3.2 Wavyzz:3.4.beta1_20130502 Wavyzz:3.4.beta1_20130429 Wavyzz:3.3.1 Wavyzz:3.3.0 Wavyzz:3.3.beta2_20120109 Wavyzz:3.3.beta1_20121221 Wavyzz:3.2.3 Wavyzz:3.2.2 Wavyzz:3.2.1 Wavyzz:3.1.3 Wavyzz:3.2.0 Wavyzz:3.1.2 Wavyzz:3.1.1 Wavyzz:3.1.0 Wavyzz:3.0.1 Wavyzz:3.0.0 Wavyzz:2.9.0 Wavyzz:2.8.1
...
compare: Wavyzz:17.0
Branches Tags
Wavyzz:develop Wavyzz:22.0 Wavyzz:21.0 Wavyzz:20.0 Wavyzz:19.0 Wavyzz:18.0 Wavyzz:17.0 Wavyzz:phpstan-baseline Wavyzz:16.0 Wavyzz:15.0 Wavyzz:14.0 Wavyzz:hregis-fix_dev_mysql_workbench Wavyzz:6.0 Wavyzz:snyk-fix-3e1e5b476824b5bd60a178613c9f4541 Wavyzz:13.0 Wavyzz:12.0 Wavyzz:11.0 Wavyzz:10.0 Wavyzz:9.0 Wavyzz:gh-pages Wavyzz:8.0 Wavyzz:7.0 Wavyzz:3.7 Wavyzz:5.0 Wavyzz:3.6 Wavyzz:4.0 Wavyzz:3.9 Wavyzz:3.8 Wavyzz:3.5 Wavyzz:3.4 Wavyzz:3.3 Wavyzz:3.2 Wavyzz:3.1 Wavyzz:3.0 Wavyzz:2.9 Wavyzz:2.8
Wavyzz:22.0.3 Wavyzz:22.0.2 Wavyzz:18.0.8 Wavyzz:22.0.1 Wavyzz:21.0.4 Wavyzz:21.0.3 Wavyzz:22.0.0 Wavyzz:21.0.2 Wavyzz:18.0.7 Wavyzz:21.0.1 Wavyzz:21.0.0 Wavyzz:20.0.4 Wavyzz:20.0.3 Wavyzz:20.0.2 Wavyzz:19.0.4 Wavyzz:18.0.6 Wavyzz:20.0.1 Wavyzz:20.0.0 Wavyzz:19.0.3 Wavyzz:19.0.2 Wavyzz:19.0.1 Wavyzz:19.0.0 Wavyzz:18.0.5 Wavyzz:17.0.4 Wavyzz:18.0.4 Wavyzz:18.0.3 Wavyzz:18.0.2 Wavyzz:18.0.1 Wavyzz:18.0.0 Wavyzz:17.0.3 Wavyzz:17.0.2 Wavyzz:17.0.1 Wavyzz:16.0.5 Wavyzz:17.0.0 Wavyzz:16.0.4 Wavyzz:16.0.3 Wavyzz:16.0.2 Wavyzz:16.0.1 Wavyzz:16.0.0 Wavyzz:15.0.3 Wavyzz:15.0.2 Wavyzz:15.0.1 Wavyzz:15.0.0 Wavyzz:14.0.5 Wavyzz:14.0.4 Wavyzz:14.0.3 Wavyzz:13.0.5 Wavyzz:14.0.2 Wavyzz:14.0.1 Wavyzz:14.0.0 Wavyzz:13.0.4 Wavyzz:13.0.3 Wavyzz:13.0.2 Wavyzz:13.0.1 Wavyzz:12.0.5 Wavyzz:13.0.0 Wavyzz:12.0.4 Wavyzz:12.0.3 Wavyzz:12.0.2 Wavyzz:12.0.1 Wavyzz:11.0.5 Wavyzz:12.0.0 Wavyzz:11.0.4 Wavyzz:10.0.7 Wavyzz:11.0.3 Wavyzz:11.0.2 Wavyzz:11.0.1 Wavyzz:11.0.0 Wavyzz:10.0.6 Wavyzz:10.0.5 Wavyzz:10.0.4 Wavyzz:10.0.3 Wavyzz:10.0.2 Wavyzz:10.0.1 Wavyzz:10.0.0 Wavyzz:9.0.4 Wavyzz:8.0.6 Wavyzz:8.0.5 Wavyzz:9.0.3 Wavyzz:9.0.2 Wavyzz:9.0.1 Wavyzz:9.0.0 Wavyzz:7.0.5 Wavyzz:8.0.4 Wavyzz:8.0.3 Wavyzz:7.0.4 Wavyzz:6.0.8 Wavyzz:8.0.2 Wavyzz:8.0.1 Wavyzz:8.0.0 Wavyzz:7.0.3 Wavyzz:7.0.2 Wavyzz:6.0.7 Wavyzz:7.0.1 Wavyzz:6.0.6 Wavyzz:7.0.0 Wavyzz:6.0.5 Wavyzz:6.0.4 Wavyzz:6.0.3 Wavyzz:5.0.7 Wavyzz:6.0.2 Wavyzz:6.0.1 Wavyzz:5.0.6 Wavyzz:6.0.0 Wavyzz:5.0.5 Wavyzz:6.0.0-rc Wavyzz:5.0.4 Wavyzz:6.0.0-beta Wavyzz:5.0.3 Wavyzz:4.0.6 Wavyzz:5.0.2 Wavyzz:5.0.1 Wavyzz:4.0.5 Wavyzz:5.0.0 Wavyzz:4.0.4 Wavyzz:5.0.0-rc2 Wavyzz:5.0.0-rc1 Wavyzz:4.0.3 Wavyzz:3.9.4 Wavyzz:5.0.0-beta Wavyzz:4.0.2 Wavyzz:4.0.1 Wavyzz:4.0.0 Wavyzz:4.0.0-rc2 Wavyzz:3.9.3 Wavyzz:4.0.0-rc Wavyzz:4.0.0-beta Wavyzz:3.9.2 Wavyzz:3.9.1 Wavyzz:3.9.0 Wavyzz:3.8.4 Wavyzz:3.7.4 Wavyzz:3.9.0-rc2 Wavyzz:3.9.0-rc Wavyzz:3.5.8 Wavyzz:3.8.3 Wavyzz:3.7.3 Wavyzz:3.6.6 Wavyzz:3.6.5 Wavyzz:3.7.2 Wavyzz:3.8.2 Wavyzz:3.8.1 Wavyzz:3.8.0 Wavyzz:3.8.0-beta Wavyzz:3.8.beta1_20150712 Wavyzz:3.7.1 Wavyzz:3.6.4 Wavyzz:3.5.7 Wavyzz:3.7.0 Wavyzz:3.6.3 Wavyzz:3.6.2 Wavyzz:3.5.6 Wavyzz:3.7.beta1_20141116 Wavyzz:3.6.1 Wavyzz:3.5.5 Wavyzz:3.6.0 Wavyzz:3.5.4 Wavyzz:3.6.0-beta Wavyzz:3.5.3 Wavyzz:3.6.beta2_20140524 Wavyzz:3.6.beta1_20140514 Wavyzz:3.5.2 Wavyzz:3.6.0-alpha Wavyzz:3.5.1 Wavyzz:3.5.0 Wavyzz:3.4.2 Wavyzz:3.5.beta1_20131120 Wavyzz:3.5.beta1_20131106 Wavyzz:3.4.1 Wavyzz:3.4.0 Wavyzz:3.3.3 Wavyzz:3.3.2 Wavyzz:3.4.beta1_20130502 Wavyzz:3.4.beta1_20130429 Wavyzz:3.3.1 Wavyzz:3.3.0 Wavyzz:3.3.beta2_20120109 Wavyzz:3.3.beta1_20121221 Wavyzz:3.2.3 Wavyzz:3.2.2 Wavyzz:3.2.1 Wavyzz:3.1.3 Wavyzz:3.2.0 Wavyzz:3.1.2 Wavyzz:3.1.1 Wavyzz:3.1.0 Wavyzz:3.0.1 Wavyzz:3.0.0 Wavyzz:2.9.0 Wavyzz:2.8.1

2 Commits
phpstan-ba ... 17.0

Author SHA1 Message Date
Laurent Destailleur
78ca968db6 Merge pull request #36517 from atm-florianm/SEC/commented-out-restrictedArea 
SEC: FIX #36430 permissions not checked on other tabs of HRM evaluation card
 2025-12-04 18:37:46 +01:00
atm-florian
a1476fd221 SEC: permissions not checked on other tabs of HRM evaluation card 2025-12-03 17:11:14 +01:00
4 changed files with 13 additions and 14 deletions
Expand all files Collapse all files

5
htdocs/hrm/evaluation_agenda.php
View File

@@ -96,8 +96,9 @@ $permissiontoread = $user->rights->hrm->evaluation->read; // Used by the include
// Security check (enable the most restrictive one) // Security check (enable the most restrictive one)
//if ($user->socid > 0) accessforbidden(); //if ($user->socid > 0) accessforbidden();
//if ($user->socid > 0) $socid = $user->socid; //if ($user->socid > 0) $socid = $user->socid;
//$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); $isdraft = $object->status == Evaluation::STATUS_DRAFT ? 1 : 0;
//restrictedArea($user, $object->module, $object->id, $object->table_element, $object->element, 'fk_soc', 'rowid', $isdraft); restrictedArea($user, $object->element, $object, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
if (!isModEnabled('hrm')) { if (!isModEnabled('hrm')) {
accessforbidden(); accessforbidden();
} }

6
htdocs/hrm/evaluation_contact.php
View File

@@ -62,10 +62,8 @@ $permission = $user->rights->hrm->evaluation->write;
// Security check (enable the most restrictive one) // Security check (enable the most restrictive one)
//if ($user->socid > 0) accessforbidden(); //if ($user->socid > 0) accessforbidden();
//if ($user->socid > 0) $socid = $user->socid; //if ($user->socid > 0) $socid = $user->socid;
//$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); $isdraft = $object->status == Evaluation::STATUS_DRAFT ? 1 : 0;
//restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft); restrictedArea($user, $object->element, $object, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
//if (empty($conf->hrm->enabled)) accessforbidden();
//if (!$permissiontoread) accessforbidden();

8
htdocs/hrm/evaluation_document.php
View File

@@ -85,10 +85,10 @@ $permissiontoadd = $user->rights->hrm->evaluation->write; // Used by the includ
$permissiontoread = $user->rights->hrm->evaluation->read; $permissiontoread = $user->rights->hrm->evaluation->read;
// Security check (enable the most restrictive one) // Security check (enable the most restrictive one)
//if ($user->socid > 0) accessforbidden();
//if ($user->socid > 0) $socid = $user->socid; $isdraft = $object->status == Evaluation::STATUS_DRAFT ? 1 : 0;
//$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); restrictedArea($user, $object->element, $object, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
//restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
if (empty($conf->hrm->enabled)) accessforbidden(); if (empty($conf->hrm->enabled)) accessforbidden();
if (!$permissiontoread) accessforbidden(); if (!$permissiontoread) accessforbidden();

8
htdocs/hrm/evaluation_note.php
View File

@@ -66,10 +66,10 @@ $permissiontoread = $user->rights->hrm->evaluation->read; // Used by the includ
// Security check (enable the most restrictive one) // Security check (enable the most restrictive one)
//if ($user->socid > 0) accessforbidden(); //if ($user->socid > 0) accessforbidden();
//if ($user->socid > 0) $socid = $user->socid; //if ($user->socid > 0) $socid = $user->socid;
//$isdraft = (($object->status == $object::STATUS_DRAFT) ? 1 : 0); $isdraft = (($object->status == Evaluation::STATUS_DRAFT) ? 1 : 0);
//restrictedArea($user, $object->element, $object->id, $object->table_element, '', 'fk_soc', 'rowid', $isdraft); restrictedArea($user, $object->element, $object, $object->table_element, '', 'fk_soc', 'rowid', $isdraft);
//if (empty($conf->hrm->enabled)) accessforbidden(); if (empty($conf->hrm->enabled)) accessforbidden();
//if (!$permissiontoread) accessforbidden(); if (!$permissiontoread) accessforbidden();
/* /*