Alexandre Janniaux 1a3430f40a
commonobject: updateLineDown: use early return on query failure ( #34598 ) ...
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.
It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-21 14:36:07 +02:00
2024-12-04 23:41:04 +01:00
2025-04-20 18:54:55 +02:00
2025-06-10 02:24:08 +02:00
2024-11-27 21:59:41 +01:00
2025-06-19 10:10:42 +02:00
2025-06-11 18:17:56 +02:00
2025-06-21 14:36:07 +02:00
2025-04-24 00:51:47 +02:00
2025-02-05 01:43:37 +01:00
2025-06-04 16:06:11 +02:00
2025-04-20 13:21:48 +02:00
2025-03-15 16:34:35 +01:00
2025-06-05 17:47:40 +02:00
2025-03-15 16:34:35 +01:00
2025-03-15 16:34:35 +01:00
2025-03-15 16:34:35 +01:00
2025-03-15 16:34:35 +01:00
2025-02-05 00:40:06 +01:00
2025-02-10 13:03:37 +01:00
2025-02-19 15:20:51 +01:00
2025-06-02 17:11:38 +02:00
2024-11-25 20:11:10 +01:00
2025-04-25 16:43:31 +02:00
2025-06-13 03:21:40 +02:00
2025-02-05 00:40:06 +01:00
2025-03-19 15:21:48 +01:00
2025-02-05 00:40:06 +01:00
2025-05-05 17:09:24 +02:00
2025-04-15 20:28:52 +02:00
2025-03-15 16:34:35 +01:00
2025-05-27 22:26:58 +02:00
2025-06-20 12:34:10 +02:00
2025-04-13 21:32:28 +02:00
2025-04-26 04:05:01 +02:00
2025-04-21 14:57:41 +02:00
2025-06-02 21:10:45 +02:00
2025-04-06 19:51:30 +02:00
2025-02-02 01:26:41 +01:00
2025-01-27 19:15:09 +01:00
2025-05-06 19:15:13 +02:00
2025-02-17 17:23:18 +01:00
2025-02-11 22:08:21 +01:00
2025-06-13 16:13:02 +02:00
2025-02-10 21:39:55 +01:00
2025-03-19 15:21:48 +01:00
2025-03-25 14:01:28 +01:00
2025-05-10 16:29:32 +02:00
2025-06-10 14:38:13 +02:00
2025-05-28 09:57:46 +02:00
2025-02-15 00:09:10 +01:00
2025-02-20 19:50:49 +01:00
2025-03-19 16:04:11 +01:00
2025-05-05 21:13:05 +02:00
2025-05-05 20:30:26 +02:00
2025-05-14 16:54:33 +02:00
2025-04-16 14:49:39 +02:00
2025-04-15 12:24:50 +02:00
2025-04-22 16:57:49 +02:00
2025-05-02 22:41:04 +02:00
2025-06-11 15:08:52 +02:00
2025-03-05 12:15:12 +01:00
2025-03-01 17:20:23 +01:00
1a3430f40a