Wavyzz/python-github-backup
2
0
Fork 0
mirror of https://github.com/josegonzalez/python-github-backup.git synced 2025-12-05 16:18:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling in case of HTTP errors

Browse Source 
In case of a HTTP status code 404, the returned 'r' was never assigned.
In case of URL errors which are not timeouts, we probably should bail
out.
This commit is contained in:
Enrico Tröger
2015-10-21 22:40:34 +02:00
parent fe162eedd5
commit 534145d178
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bin/github-backup
View File

@@ -304,8 +304,11 @@ def _get_response(request, auth, template):
r = urllib2.urlopen(request) r = urllib2.urlopen(request)
except urllib2.HTTPError as exc: except urllib2.HTTPError as exc:
errors, should_continue = _request_http_error(exc, auth, errors) # noqa errors, should_continue = _request_http_error(exc, auth, errors) # noqa
r = exc
except urllib2.URLError: except urllib2.URLError:
should_continue = _request_url_error(template, retry_timeout) should_continue = _request_url_error(template, retry_timeout)
if not should_continue:
raise
if should_continue: if should_continue:
continue continue