mirror of
https://github.com/josegonzalez/python-github-backup.git
synced 2025-12-08 17:28:02 +01:00
Compare commits
16 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
eb5779ac23 | ||
|
|
5b52931ebf | ||
|
|
1d6d474408 | ||
|
|
b80049e96e | ||
|
|
58ad1c2378 | ||
|
|
6e2a7e521c | ||
|
|
aba048a3e9 | ||
|
|
9f7c08166f | ||
|
|
fdfaaec1ba | ||
|
|
8f9cf7ff89 | ||
|
|
899ab5fdc2 | ||
|
|
2a9d86a6bf | ||
|
|
4fd3ea9e3c | ||
|
|
041dc013f9 | ||
|
|
12802103c4 | ||
|
|
bf28b46954 |
56
CHANGES.rst
56
CHANGES.rst
@@ -1,10 +1,64 @@
|
|||||||
Changelog
|
Changelog
|
||||||
=========
|
=========
|
||||||
|
|
||||||
0.53.0 (2025-11-30)
|
0.55.0 (2025-12-07)
|
||||||
-------------------
|
-------------------
|
||||||
------------------------
|
------------------------
|
||||||
|
|
||||||
|
Fix
|
||||||
|
~~~
|
||||||
|
- Improve error messages for inaccessible repos and empty wikis. [Rodos]
|
||||||
|
- --all-starred now clones repos without --repositories. [Rodos]
|
||||||
|
- Warn when --private used without authentication. [Rodos]
|
||||||
|
- Warn and skip when --starred-gists used for different user. [Rodos]
|
||||||
|
|
||||||
|
GitHub's API only allows retrieving starred gists for the authenticated
|
||||||
|
user. Previously, using --starred-gists when backing up a different user
|
||||||
|
would silently return no relevant data.
|
||||||
|
|
||||||
|
Now warns and skips the retrieval entirely when the target user differs
|
||||||
|
from the authenticated user. Uses case-insensitive comparison to match
|
||||||
|
GitHub's username handling.
|
||||||
|
|
||||||
|
Fixes #93
|
||||||
|
|
||||||
|
Other
|
||||||
|
~~~~~
|
||||||
|
- Test: add missing test coverage for case sensitivity fix. [Rodos]
|
||||||
|
- Docs: fix RST formatting in Known blocking errors section. [Rodos]
|
||||||
|
- Chore(deps): bump urllib3 from 2.5.0 to 2.6.0. [dependabot[bot]]
|
||||||
|
|
||||||
|
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.5.0 to 2.6.0.
|
||||||
|
- [Release notes](https://github.com/urllib3/urllib3/releases)
|
||||||
|
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
|
||||||
|
- [Commits](https://github.com/urllib3/urllib3/compare/2.5.0...2.6.0)
|
||||||
|
|
||||||
|
---
|
||||||
|
updated-dependencies:
|
||||||
|
- dependency-name: urllib3
|
||||||
|
dependency-version: 2.6.0
|
||||||
|
dependency-type: direct:production
|
||||||
|
...
|
||||||
|
|
||||||
|
|
||||||
|
0.54.0 (2025-12-03)
|
||||||
|
-------------------
|
||||||
|
|
||||||
|
Fix
|
||||||
|
~~~
|
||||||
|
- Send INFO/DEBUG to stdout, WARNING/ERROR to stderr. [Rodos]
|
||||||
|
|
||||||
|
Fixes #182
|
||||||
|
|
||||||
|
Other
|
||||||
|
~~~~~
|
||||||
|
- Docs: update README testing section and add fetch vs pull explanation.
|
||||||
|
[Rodos]
|
||||||
|
|
||||||
|
|
||||||
|
0.53.0 (2025-11-30)
|
||||||
|
-------------------
|
||||||
|
|
||||||
Fix
|
Fix
|
||||||
~~~
|
~~~
|
||||||
- Case-sensitive username filtering causing silent backup failures.
|
- Case-sensitive username filtering causing silent backup failures.
|
||||||
|
|||||||
30
README.rst
30
README.rst
@@ -281,7 +281,7 @@ If the incremental argument is used, this will result in the next backup only re
|
|||||||
|
|
||||||
It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
|
It's therefore recommended to only use the incremental argument if the output/result is being actively monitored, or complimented with periodic full non-incremental runs, to avoid unexpected missing data in a regular backup runs.
|
||||||
|
|
||||||
1. **Starred public repo hooks blocking**
|
**Starred public repo hooks blocking**
|
||||||
|
|
||||||
Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
|
Since the ``--all`` argument includes ``--hooks``, if you use ``--all`` and ``--all-starred`` together to clone a users starred public repositories, the backup will likely error and block the backup continuing.
|
||||||
|
|
||||||
@@ -301,6 +301,8 @@ Starred gists vs starred repo behaviour
|
|||||||
|
|
||||||
The starred normal repo cloning (``--all-starred``) argument stores starred repos separately to the users own repositories. However, using ``--starred-gists`` will store starred gists within the same directory as the users own gists ``--gists``. Also, all gist repo directory names are IDs not the gist's name.
|
The starred normal repo cloning (``--all-starred``) argument stores starred repos separately to the users own repositories. However, using ``--starred-gists`` will store starred gists within the same directory as the users own gists ``--gists``. Also, all gist repo directory names are IDs not the gist's name.
|
||||||
|
|
||||||
|
Note: ``--starred-gists`` only retrieves starred gists for the authenticated user, not the target user, due to a GitHub API limitation.
|
||||||
|
|
||||||
|
|
||||||
Skip existing on incomplete backups
|
Skip existing on incomplete backups
|
||||||
-----------------------------------
|
-----------------------------------
|
||||||
@@ -308,6 +310,25 @@ Skip existing on incomplete backups
|
|||||||
The ``--skip-existing`` argument will skip a backup if the directory already exists, even if the backup in that directory failed (perhaps due to a blocking error). This may result in unexpected missing data in a regular backup.
|
The ``--skip-existing`` argument will skip a backup if the directory already exists, even if the backup in that directory failed (perhaps due to a blocking error). This may result in unexpected missing data in a regular backup.
|
||||||
|
|
||||||
|
|
||||||
|
Updates use fetch, not pull
|
||||||
|
---------------------------
|
||||||
|
|
||||||
|
When updating an existing repository backup, ``github-backup`` uses ``git fetch`` rather than ``git pull``. This is intentional - a backup tool should reliably download data without risk of failure. Using ``git pull`` would require handling merge conflicts, which adds complexity and could cause backups to fail unexpectedly.
|
||||||
|
|
||||||
|
With fetch, **all branches and commits are downloaded** safely into remote-tracking branches. The working directory files won't change, but your backup is complete.
|
||||||
|
|
||||||
|
If you look at files directly (e.g., ``cat README.md``), you'll see the old content. The new data is in the remote-tracking branches (confusingly named "remote" but stored locally). To view or use the latest files::
|
||||||
|
|
||||||
|
git show origin/main:README.md # view a file
|
||||||
|
git merge origin/main # update working directory
|
||||||
|
|
||||||
|
All branches are backed up as remote refs (``origin/main``, ``origin/feature-branch``, etc.).
|
||||||
|
|
||||||
|
If you want to browse files directly without merging, consider using ``--bare`` which skips the working directory entirely - the backup is just the git data.
|
||||||
|
|
||||||
|
See `#269 <https://github.com/josegonzalez/python-github-backup/issues/269>`_ for more discussion.
|
||||||
|
|
||||||
|
|
||||||
Github Backup Examples
|
Github Backup Examples
|
||||||
======================
|
======================
|
||||||
|
|
||||||
@@ -357,7 +378,12 @@ A huge thanks to all the contibuters!
|
|||||||
Testing
|
Testing
|
||||||
-------
|
-------
|
||||||
|
|
||||||
This project currently contains no unit tests. To run linting::
|
To run the test suite::
|
||||||
|
|
||||||
|
pip install pytest
|
||||||
|
pytest
|
||||||
|
|
||||||
|
To run linting::
|
||||||
|
|
||||||
pip install flake8
|
pip install flake8
|
||||||
flake8 --ignore=E501
|
flake8 --ignore=E501
|
||||||
|
|||||||
@@ -9,6 +9,7 @@ from github_backup.github_backup import (
|
|||||||
backup_repositories,
|
backup_repositories,
|
||||||
check_git_lfs_install,
|
check_git_lfs_install,
|
||||||
filter_repositories,
|
filter_repositories,
|
||||||
|
get_auth,
|
||||||
get_authenticated_user,
|
get_authenticated_user,
|
||||||
logger,
|
logger,
|
||||||
mkdir_p,
|
mkdir_p,
|
||||||
@@ -16,16 +17,33 @@ from github_backup.github_backup import (
|
|||||||
retrieve_repositories,
|
retrieve_repositories,
|
||||||
)
|
)
|
||||||
|
|
||||||
logging.basicConfig(
|
# INFO and DEBUG go to stdout, WARNING and above go to stderr
|
||||||
format="%(asctime)s.%(msecs)03d: %(message)s",
|
log_format = logging.Formatter(
|
||||||
|
fmt="%(asctime)s.%(msecs)03d: %(message)s",
|
||||||
datefmt="%Y-%m-%dT%H:%M:%S",
|
datefmt="%Y-%m-%dT%H:%M:%S",
|
||||||
level=logging.INFO,
|
|
||||||
)
|
)
|
||||||
|
|
||||||
|
stdout_handler = logging.StreamHandler(sys.stdout)
|
||||||
|
stdout_handler.setLevel(logging.DEBUG)
|
||||||
|
stdout_handler.addFilter(lambda r: r.levelno < logging.WARNING)
|
||||||
|
stdout_handler.setFormatter(log_format)
|
||||||
|
|
||||||
|
stderr_handler = logging.StreamHandler(sys.stderr)
|
||||||
|
stderr_handler.setLevel(logging.WARNING)
|
||||||
|
stderr_handler.setFormatter(log_format)
|
||||||
|
|
||||||
|
logging.basicConfig(level=logging.INFO, handlers=[stdout_handler, stderr_handler])
|
||||||
|
|
||||||
|
|
||||||
def main():
|
def main():
|
||||||
args = parse_args()
|
args = parse_args()
|
||||||
|
|
||||||
|
if args.private and not get_auth(args):
|
||||||
|
logger.warning(
|
||||||
|
"The --private flag has no effect without authentication. "
|
||||||
|
"Use -t/--token, -f/--token-fine, or -u/--username to authenticate."
|
||||||
|
)
|
||||||
|
|
||||||
if args.quiet:
|
if args.quiet:
|
||||||
logger.setLevel(logging.WARNING)
|
logger.setLevel(logging.WARNING)
|
||||||
|
|
||||||
|
|||||||
@@ -1 +1 @@
|
|||||||
__version__ = "0.53.0"
|
__version__ = "0.55.0"
|
||||||
|
|||||||
@@ -1565,6 +1565,12 @@ def retrieve_repositories(args, authenticated_user):
|
|||||||
repos.extend(gists)
|
repos.extend(gists)
|
||||||
|
|
||||||
if args.include_starred_gists:
|
if args.include_starred_gists:
|
||||||
|
if not authenticated_user.get("login") or args.user.lower() != authenticated_user["login"].lower():
|
||||||
|
logger.warning(
|
||||||
|
"Cannot retrieve starred gists for '%s'. GitHub only allows access to the authenticated user's starred gists.",
|
||||||
|
args.user,
|
||||||
|
)
|
||||||
|
else:
|
||||||
starred_gists_template = "https://{0}/gists/starred".format(
|
starred_gists_template = "https://{0}/gists/starred".format(
|
||||||
get_github_api_host(args)
|
get_github_api_host(args)
|
||||||
)
|
)
|
||||||
@@ -1666,9 +1672,10 @@ def backup_repositories(args, output_directory, repositories):
|
|||||||
repo_url = get_github_repo_url(args, repository)
|
repo_url = get_github_repo_url(args, repository)
|
||||||
|
|
||||||
include_gists = args.include_gists or args.include_starred_gists
|
include_gists = args.include_gists or args.include_starred_gists
|
||||||
|
include_starred = args.all_starred and repository.get("is_starred")
|
||||||
if (args.include_repository or args.include_everything) or (
|
if (args.include_repository or args.include_everything) or (
|
||||||
include_gists and repository.get("is_gist")
|
include_gists and repository.get("is_gist")
|
||||||
):
|
) or include_starred:
|
||||||
repo_name = (
|
repo_name = (
|
||||||
repository.get("name")
|
repository.get("name")
|
||||||
if not repository.get("is_gist")
|
if not repository.get("is_gist")
|
||||||
@@ -2017,12 +2024,9 @@ def fetch_repository(
|
|||||||
):
|
):
|
||||||
if bare_clone:
|
if bare_clone:
|
||||||
if os.path.exists(local_dir):
|
if os.path.exists(local_dir):
|
||||||
clone_exists = (
|
clone_exists = subprocess.check_output(
|
||||||
subprocess.check_output(
|
|
||||||
["git", "rev-parse", "--is-bare-repository"], cwd=local_dir
|
["git", "rev-parse", "--is-bare-repository"], cwd=local_dir
|
||||||
)
|
) == b"true\n"
|
||||||
== b"true\n"
|
|
||||||
)
|
|
||||||
else:
|
else:
|
||||||
clone_exists = False
|
clone_exists = False
|
||||||
else:
|
else:
|
||||||
@@ -2037,10 +2041,13 @@ def fetch_repository(
|
|||||||
"git ls-remote " + remote_url, stdout=FNULL, stderr=FNULL, shell=True
|
"git ls-remote " + remote_url, stdout=FNULL, stderr=FNULL, shell=True
|
||||||
)
|
)
|
||||||
if initialized == 128:
|
if initialized == 128:
|
||||||
|
if ".wiki.git" in remote_url:
|
||||||
logger.info(
|
logger.info(
|
||||||
"Skipping {0} ({1}) since it's not initialized".format(
|
"Skipping {0} wiki (wiki is enabled but has no content)".format(name)
|
||||||
name, masked_remote_url
|
|
||||||
)
|
)
|
||||||
|
else:
|
||||||
|
logger.info(
|
||||||
|
"Skipping {0} (repository not accessible - may be empty, private, or credentials invalid)".format(name)
|
||||||
)
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
|
|||||||
@@ -35,6 +35,6 @@ setuptools==80.9.0
|
|||||||
six==1.17.0
|
six==1.17.0
|
||||||
tqdm==4.67.1
|
tqdm==4.67.1
|
||||||
twine==6.2.0
|
twine==6.2.0
|
||||||
urllib3==2.5.0
|
urllib3==2.6.0
|
||||||
webencodings==0.5.1
|
webencodings==0.5.1
|
||||||
zipp==3.23.0
|
zipp==3.23.0
|
||||||
|
|||||||
161
tests/test_all_starred.py
Normal file
161
tests/test_all_starred.py
Normal file
@@ -0,0 +1,161 @@
|
|||||||
|
"""Tests for --all-starred flag behavior (issue #225)."""
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from unittest.mock import Mock, patch
|
||||||
|
|
||||||
|
from github_backup import github_backup
|
||||||
|
|
||||||
|
|
||||||
|
class TestAllStarredCloning:
|
||||||
|
"""Test suite for --all-starred repository cloning behavior.
|
||||||
|
|
||||||
|
Issue #225: --all-starred should clone starred repos without requiring --repositories.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def _create_mock_args(self, **overrides):
|
||||||
|
"""Create a mock args object with sensible defaults."""
|
||||||
|
args = Mock()
|
||||||
|
args.user = "testuser"
|
||||||
|
args.output_directory = "/tmp/backup"
|
||||||
|
args.include_repository = False
|
||||||
|
args.include_everything = False
|
||||||
|
args.include_gists = False
|
||||||
|
args.include_starred_gists = False
|
||||||
|
args.all_starred = False
|
||||||
|
args.skip_existing = False
|
||||||
|
args.bare_clone = False
|
||||||
|
args.lfs_clone = False
|
||||||
|
args.no_prune = False
|
||||||
|
args.include_wiki = False
|
||||||
|
args.include_issues = False
|
||||||
|
args.include_issue_comments = False
|
||||||
|
args.include_issue_events = False
|
||||||
|
args.include_pulls = False
|
||||||
|
args.include_pull_comments = False
|
||||||
|
args.include_pull_commits = False
|
||||||
|
args.include_pull_details = False
|
||||||
|
args.include_labels = False
|
||||||
|
args.include_hooks = False
|
||||||
|
args.include_milestones = False
|
||||||
|
args.include_releases = False
|
||||||
|
args.include_assets = False
|
||||||
|
args.include_attachments = False
|
||||||
|
args.incremental = False
|
||||||
|
args.incremental_by_files = False
|
||||||
|
args.github_host = None
|
||||||
|
args.prefer_ssh = False
|
||||||
|
args.token_classic = None
|
||||||
|
args.token_fine = None
|
||||||
|
args.username = None
|
||||||
|
args.password = None
|
||||||
|
args.as_app = False
|
||||||
|
args.osx_keychain_item_name = None
|
||||||
|
args.osx_keychain_item_account = None
|
||||||
|
|
||||||
|
for key, value in overrides.items():
|
||||||
|
setattr(args, key, value)
|
||||||
|
|
||||||
|
return args
|
||||||
|
|
||||||
|
@patch('github_backup.github_backup.fetch_repository')
|
||||||
|
@patch('github_backup.github_backup.get_github_repo_url')
|
||||||
|
def test_all_starred_clones_without_repositories_flag(self, mock_get_url, mock_fetch):
|
||||||
|
"""--all-starred should clone starred repos without --repositories flag.
|
||||||
|
|
||||||
|
This is the core fix for issue #225.
|
||||||
|
"""
|
||||||
|
args = self._create_mock_args(all_starred=True)
|
||||||
|
mock_get_url.return_value = "https://github.com/otheruser/awesome-project.git"
|
||||||
|
|
||||||
|
# A starred repository (is_starred flag set by retrieve_repositories)
|
||||||
|
starred_repo = {
|
||||||
|
"name": "awesome-project",
|
||||||
|
"full_name": "otheruser/awesome-project",
|
||||||
|
"owner": {"login": "otheruser"},
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
"has_wiki": False,
|
||||||
|
"is_starred": True, # This flag is set for starred repos
|
||||||
|
}
|
||||||
|
|
||||||
|
with patch('github_backup.github_backup.mkdir_p'):
|
||||||
|
github_backup.backup_repositories(args, "/tmp/backup", [starred_repo])
|
||||||
|
|
||||||
|
# fetch_repository should be called for the starred repo
|
||||||
|
assert mock_fetch.called, "--all-starred should trigger repository cloning"
|
||||||
|
mock_fetch.assert_called_once()
|
||||||
|
call_args = mock_fetch.call_args
|
||||||
|
assert call_args[0][0] == "awesome-project" # repo name
|
||||||
|
|
||||||
|
@patch('github_backup.github_backup.fetch_repository')
|
||||||
|
@patch('github_backup.github_backup.get_github_repo_url')
|
||||||
|
def test_starred_repo_not_cloned_without_all_starred_flag(self, mock_get_url, mock_fetch):
|
||||||
|
"""Starred repos should NOT be cloned if --all-starred is not set."""
|
||||||
|
args = self._create_mock_args(all_starred=False)
|
||||||
|
mock_get_url.return_value = "https://github.com/otheruser/awesome-project.git"
|
||||||
|
|
||||||
|
starred_repo = {
|
||||||
|
"name": "awesome-project",
|
||||||
|
"full_name": "otheruser/awesome-project",
|
||||||
|
"owner": {"login": "otheruser"},
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
"has_wiki": False,
|
||||||
|
"is_starred": True,
|
||||||
|
}
|
||||||
|
|
||||||
|
with patch('github_backup.github_backup.mkdir_p'):
|
||||||
|
github_backup.backup_repositories(args, "/tmp/backup", [starred_repo])
|
||||||
|
|
||||||
|
# fetch_repository should NOT be called
|
||||||
|
assert not mock_fetch.called, "Starred repos should not be cloned without --all-starred"
|
||||||
|
|
||||||
|
@patch('github_backup.github_backup.fetch_repository')
|
||||||
|
@patch('github_backup.github_backup.get_github_repo_url')
|
||||||
|
def test_non_starred_repo_not_cloned_with_only_all_starred(self, mock_get_url, mock_fetch):
|
||||||
|
"""Non-starred repos should NOT be cloned when only --all-starred is set."""
|
||||||
|
args = self._create_mock_args(all_starred=True)
|
||||||
|
mock_get_url.return_value = "https://github.com/testuser/my-project.git"
|
||||||
|
|
||||||
|
# A regular (non-starred) repository
|
||||||
|
regular_repo = {
|
||||||
|
"name": "my-project",
|
||||||
|
"full_name": "testuser/my-project",
|
||||||
|
"owner": {"login": "testuser"},
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
"has_wiki": False,
|
||||||
|
# No is_starred flag
|
||||||
|
}
|
||||||
|
|
||||||
|
with patch('github_backup.github_backup.mkdir_p'):
|
||||||
|
github_backup.backup_repositories(args, "/tmp/backup", [regular_repo])
|
||||||
|
|
||||||
|
# fetch_repository should NOT be called for non-starred repos
|
||||||
|
assert not mock_fetch.called, "Non-starred repos should not be cloned with only --all-starred"
|
||||||
|
|
||||||
|
@patch('github_backup.github_backup.fetch_repository')
|
||||||
|
@patch('github_backup.github_backup.get_github_repo_url')
|
||||||
|
def test_repositories_flag_still_works(self, mock_get_url, mock_fetch):
|
||||||
|
"""--repositories flag should still clone repos as before."""
|
||||||
|
args = self._create_mock_args(include_repository=True)
|
||||||
|
mock_get_url.return_value = "https://github.com/testuser/my-project.git"
|
||||||
|
|
||||||
|
regular_repo = {
|
||||||
|
"name": "my-project",
|
||||||
|
"full_name": "testuser/my-project",
|
||||||
|
"owner": {"login": "testuser"},
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
"has_wiki": False,
|
||||||
|
}
|
||||||
|
|
||||||
|
with patch('github_backup.github_backup.mkdir_p'):
|
||||||
|
github_backup.backup_repositories(args, "/tmp/backup", [regular_repo])
|
||||||
|
|
||||||
|
# fetch_repository should be called
|
||||||
|
assert mock_fetch.called, "--repositories should trigger repository cloning"
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
pytest.main([__file__, "-v"])
|
||||||
112
tests/test_case_sensitivity.py
Normal file
112
tests/test_case_sensitivity.py
Normal file
@@ -0,0 +1,112 @@
|
|||||||
|
"""Tests for case-insensitive username/organization filtering."""
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from unittest.mock import Mock
|
||||||
|
|
||||||
|
from github_backup import github_backup
|
||||||
|
|
||||||
|
|
||||||
|
class TestCaseSensitivity:
|
||||||
|
"""Test suite for case-insensitive username matching in filter_repositories."""
|
||||||
|
|
||||||
|
def test_filter_repositories_case_insensitive_user(self):
|
||||||
|
"""Should filter repositories case-insensitively for usernames.
|
||||||
|
|
||||||
|
Reproduces issue #198 where typing 'iamrodos' fails to match
|
||||||
|
repositories with owner.login='Iamrodos' (the canonical case from GitHub API).
|
||||||
|
"""
|
||||||
|
# Simulate user typing lowercase username
|
||||||
|
args = Mock()
|
||||||
|
args.user = "iamrodos" # lowercase (what user typed)
|
||||||
|
args.repository = None
|
||||||
|
args.name_regex = None
|
||||||
|
args.languages = None
|
||||||
|
args.exclude = None
|
||||||
|
args.fork = False
|
||||||
|
args.private = False
|
||||||
|
args.public = False
|
||||||
|
args.all = True
|
||||||
|
|
||||||
|
# Simulate GitHub API returning canonical case
|
||||||
|
repos = [
|
||||||
|
{
|
||||||
|
"name": "repo1",
|
||||||
|
"owner": {"login": "Iamrodos"}, # Capital I (canonical from API)
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"name": "repo2",
|
||||||
|
"owner": {"login": "Iamrodos"},
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
},
|
||||||
|
]
|
||||||
|
|
||||||
|
filtered = github_backup.filter_repositories(args, repos)
|
||||||
|
|
||||||
|
# Should match despite case difference
|
||||||
|
assert len(filtered) == 2
|
||||||
|
assert filtered[0]["name"] == "repo1"
|
||||||
|
assert filtered[1]["name"] == "repo2"
|
||||||
|
|
||||||
|
def test_filter_repositories_case_insensitive_org(self):
|
||||||
|
"""Should filter repositories case-insensitively for organizations.
|
||||||
|
|
||||||
|
Tests the example from issue #198 where 'prai-org' doesn't match 'PRAI-Org'.
|
||||||
|
"""
|
||||||
|
args = Mock()
|
||||||
|
args.user = "prai-org" # lowercase (what user typed)
|
||||||
|
args.repository = None
|
||||||
|
args.name_regex = None
|
||||||
|
args.languages = None
|
||||||
|
args.exclude = None
|
||||||
|
args.fork = False
|
||||||
|
args.private = False
|
||||||
|
args.public = False
|
||||||
|
args.all = True
|
||||||
|
|
||||||
|
repos = [
|
||||||
|
{
|
||||||
|
"name": "repo1",
|
||||||
|
"owner": {"login": "PRAI-Org"}, # Different case (canonical from API)
|
||||||
|
"private": False,
|
||||||
|
"fork": False,
|
||||||
|
},
|
||||||
|
]
|
||||||
|
|
||||||
|
filtered = github_backup.filter_repositories(args, repos)
|
||||||
|
|
||||||
|
# Should match despite case difference
|
||||||
|
assert len(filtered) == 1
|
||||||
|
assert filtered[0]["name"] == "repo1"
|
||||||
|
|
||||||
|
def test_filter_repositories_case_variations(self):
|
||||||
|
"""Should handle various case combinations correctly."""
|
||||||
|
args = Mock()
|
||||||
|
args.user = "TeSt-UsEr" # Mixed case
|
||||||
|
args.repository = None
|
||||||
|
args.name_regex = None
|
||||||
|
args.languages = None
|
||||||
|
args.exclude = None
|
||||||
|
args.fork = False
|
||||||
|
args.private = False
|
||||||
|
args.public = False
|
||||||
|
args.all = True
|
||||||
|
|
||||||
|
repos = [
|
||||||
|
{"name": "repo1", "owner": {"login": "test-user"}, "private": False, "fork": False},
|
||||||
|
{"name": "repo2", "owner": {"login": "TEST-USER"}, "private": False, "fork": False},
|
||||||
|
{"name": "repo3", "owner": {"login": "TeSt-UsEr"}, "private": False, "fork": False},
|
||||||
|
{"name": "repo4", "owner": {"login": "other-user"}, "private": False, "fork": False},
|
||||||
|
]
|
||||||
|
|
||||||
|
filtered = github_backup.filter_repositories(args, repos)
|
||||||
|
|
||||||
|
# Should match first 3 (all case variations of same user)
|
||||||
|
assert len(filtered) == 3
|
||||||
|
assert set(r["name"] for r in filtered) == {"repo1", "repo2", "repo3"}
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
pytest.main([__file__, "-v"])
|
||||||
Reference in New Issue
Block a user