mirror of
https://github.com/josegonzalez/python-github-backup.git
synced 2025-12-17 13:11:11 +01:00
46140b0ff1
Refactors error handling to retry all 5xx errors (not just 502), network errors (URLError, socket.error, IncompleteRead), and JSON parse errors with exponential backoff and jitter. Respects retry-after and rate limit headers per GitHub API requirements. Consolidates retry logic into make_request_with_retry() wrapper and adds clear logging for retry attempts and failures. Removes dead code from 2016 (errors list, _request_http_error, _request_url_error) that was intentionally disabled in commit 1e5a9048 to fix #29.
Fixes #140, #110, #138
101 lines
3.9 KiB
Python
101 lines
3.9 KiB
Python
"""Tests for HTTP 451 (DMCA takedown) handling."""
|
|
|
|
import json
|
|
from unittest.mock import Mock, patch
|
|
|
|
import pytest
|
|
|
|
from github_backup import github_backup
|
|
|
|
|
|
class TestHTTP451Exception:
|
|
"""Test suite for HTTP 451 DMCA takedown exception handling."""
|
|
|
|
def test_repository_unavailable_error_raised(self):
|
|
"""HTTP 451 should raise RepositoryUnavailableError with DMCA URL."""
|
|
args = Mock()
|
|
args.as_app = False
|
|
args.token_fine = None
|
|
args.token_classic = None
|
|
args.username = None
|
|
args.password = None
|
|
args.osx_keychain_item_name = None
|
|
args.osx_keychain_item_account = None
|
|
args.throttle_limit = None
|
|
args.throttle_pause = 0
|
|
|
|
mock_response = Mock()
|
|
mock_response.getcode.return_value = 451
|
|
|
|
dmca_data = {
|
|
"message": "Repository access blocked",
|
|
"block": {
|
|
"reason": "dmca",
|
|
"created_at": "2024-11-12T14:38:04Z",
|
|
"html_url": "https://github.com/github/dmca/blob/master/2024/11/2024-11-04-source-code.md"
|
|
}
|
|
}
|
|
mock_response.read.return_value = json.dumps(dmca_data).encode("utf-8")
|
|
mock_response.headers = {"x-ratelimit-remaining": "5000"}
|
|
mock_response.reason = "Unavailable For Legal Reasons"
|
|
|
|
with patch("github_backup.github_backup.make_request_with_retry", return_value=mock_response):
|
|
with pytest.raises(github_backup.RepositoryUnavailableError) as exc_info:
|
|
github_backup.retrieve_data(args, "https://api.github.com/repos/test/dmca/issues")
|
|
|
|
assert exc_info.value.dmca_url == "https://github.com/github/dmca/blob/master/2024/11/2024-11-04-source-code.md"
|
|
assert "451" in str(exc_info.value)
|
|
|
|
def test_repository_unavailable_error_without_dmca_url(self):
|
|
"""HTTP 451 without DMCA details should still raise exception."""
|
|
args = Mock()
|
|
args.as_app = False
|
|
args.token_fine = None
|
|
args.token_classic = None
|
|
args.username = None
|
|
args.password = None
|
|
args.osx_keychain_item_name = None
|
|
args.osx_keychain_item_account = None
|
|
args.throttle_limit = None
|
|
args.throttle_pause = 0
|
|
|
|
mock_response = Mock()
|
|
mock_response.getcode.return_value = 451
|
|
mock_response.read.return_value = b'{"message": "Blocked"}'
|
|
mock_response.headers = {"x-ratelimit-remaining": "5000"}
|
|
mock_response.reason = "Unavailable For Legal Reasons"
|
|
|
|
with patch("github_backup.github_backup.make_request_with_retry", return_value=mock_response):
|
|
with pytest.raises(github_backup.RepositoryUnavailableError) as exc_info:
|
|
github_backup.retrieve_data(args, "https://api.github.com/repos/test/dmca/issues")
|
|
|
|
assert exc_info.value.dmca_url is None
|
|
assert "451" in str(exc_info.value)
|
|
|
|
def test_repository_unavailable_error_with_malformed_json(self):
|
|
"""HTTP 451 with malformed JSON should still raise exception."""
|
|
args = Mock()
|
|
args.as_app = False
|
|
args.token_fine = None
|
|
args.token_classic = None
|
|
args.username = None
|
|
args.password = None
|
|
args.osx_keychain_item_name = None
|
|
args.osx_keychain_item_account = None
|
|
args.throttle_limit = None
|
|
args.throttle_pause = 0
|
|
|
|
mock_response = Mock()
|
|
mock_response.getcode.return_value = 451
|
|
mock_response.read.return_value = b"invalid json {"
|
|
mock_response.headers = {"x-ratelimit-remaining": "5000"}
|
|
mock_response.reason = "Unavailable For Legal Reasons"
|
|
|
|
with patch("github_backup.github_backup.make_request_with_retry", return_value=mock_response):
|
|
with pytest.raises(github_backup.RepositoryUnavailableError):
|
|
github_backup.retrieve_data(args, "https://api.github.com/repos/test/dmca/issues")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v"])
|