Hoist control for exiting script a level up (#348)

* Hoist control for exiting script a level up

* Do not accidentally nil out errors

* Log when running schedule

* Remove duplicate log line

* Warn on cron schedule that will never run

cmd/backup/main.go

@@ -9,7 +9,6 @@ import (
 	"log/slog"
 	"os"
 	"os/signal"
-	"runtime"
 	"syscall"
 
 	"github.com/robfig/cron/v3"
@@ -123,7 +122,7 @@ func runScript(c *Config) (err error) {
 	return runErr
 }
 
-func (c *command) runInForeground(profileCronExpression string) error {
+func (c *command) runInForeground() error {
 	cr := cron.New(
 		cron.WithParser(
 			cron.NewParser(
@@ -190,28 +189,6 @@ func (c *command) runInForeground(profileCronExpression string) error {
 		}
 	}
 
-	if profileCronExpression != "" {
-		if _, err := cr.AddFunc(profileCronExpression, func() {
-			memStats := runtime.MemStats{}
-			runtime.ReadMemStats(&memStats)
-			c.logger.Info(
-				"Collecting runtime information",
-				"num_goroutines",
-				runtime.NumGoroutine(),
-				"memory_heap_alloc",
-				formatBytes(memStats.HeapAlloc, false),
-				"memory_heap_inuse",
-				formatBytes(memStats.HeapInuse, false),
-				"memory_heap_sys",
-				formatBytes(memStats.HeapSys, false),
-				"memory_heap_objects",
-				memStats.HeapObjects,
-			)
-		}); err != nil {
-			return fmt.Errorf("runInForeground: error adding profiling job: %w", err)
-		}
-	}
-
 	var quit = make(chan os.Signal, 1)
 	signal.Notify(quit, syscall.SIGTERM, syscall.SIGINT)
 	cr.Start()
@@ -237,12 +214,11 @@ func (c *command) runAsCommand() error {
 
 func main() {
 	foreground := flag.Bool("foreground", false, "run the tool in the foreground")
-	profile := flag.String("profile", "", "collect runtime metrics and log them periodically on the given cron expression")
 	flag.Parse()
 
 	c := newCommand()
 	if *foreground {
-		c.must(c.runInForeground(*profile))
+		c.must(c.runInForeground())
 	} else {
 		c.must(c.runAsCommand())
 	}

cmd/backup/script.go

@@ -112,12 +112,6 @@ func newScript(c *Config) (*script, error) {
 			return nil, fmt.Errorf("newScript: failed to create docker client")
 		}
 		s.cli = cli
-		s.registerHook(hookLevelPlumbing, func(err error) error {
-			if err := s.cli.Close(); err != nil {
-				return fmt.Errorf("newScript: failed to close docker client: %w", err)
-			}
-			return nil
-		})
 	}
 
 	logFunc := func(logType storage.LogLevel, context string, msg string, params ...any) {