Merge pull request #28804 from mdeweerd/fix/PhanPluginUnknownFunctionParamType

Fix & enable PhanPluginUnknownFunctionParamType

dev/tools/phan/config.php

@@ -466,7 +466,7 @@ return [
 		// 'PhanPluginNoCommentOnFunction',
 		'PhanPluginUnknownArrayFunctionParamType',
 		// 'PhanPluginDescriptionlessCommentOnPublicProperty',
-		'PhanPluginUnknownFunctionParamType',
+		// 'PhanPluginUnknownFunctionParamType',  // Finds certain errors in PHPdoc typing
 		'PhanTypeSuspiciousStringExpression',
 		// 'PhanPluginRedundantAssignment',
 

htdocs/core/lib/functions.lib.php

@@ -10319,8 +10319,8 @@ function getLanguageCodeFromCountryCode($countrycode)
  *  @param	Conf			$conf           Object conf
  *  @param  Translate		$langs          Object langs
  *  @param  object|null		$object         Object object
- *  @param  array			$head          	Object head
- *  @param  int				$h				New position to fill
+ *  @param  array<array<int,string>>	$head          	List of head tabs (updated by this function)
+ *  @param  int				$h				New position to fill (updated by this function)
  *  @param  string			$type           Value for object where objectvalue can be
  *                              			'thirdparty'       to add a tab in third party view
  *		                        	      	'intervention'     to add a tab in intervention view

htdocs/eventorganization/lib/eventorganization_conferenceorbooth.lib.php

@@ -1,6 +1,7 @@
 <?php
 /* Copyright (C) ---Put here your own copyright and developer email---
  * Copyright (C) 2024       Frédéric France             <frederic.france@free.fr>
+ * Copyright (C) 2024		MDW							<mdeweerd@users.noreply.github.com>
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -114,7 +115,7 @@ function conferenceorboothPrepareHead($object, $with_project = 0)
 /**
  * Prepare array of tabs for ConferenceOrBooth Project tab
  *
- * @param $object Project Project
+ * @param Project $object Project
  * @return array
  */
 function conferenceorboothProjectPrepareHead($object)
@@ -190,7 +191,7 @@ function conferenceorboothProjectPrepareHead($object)
  * Prepare array of tabs for ConferenceOrBoothAttendees
  *
  * @param	ConferenceOrBoothAttendee	$object		ConferenceOrBoothAttendee
- * @return 	array					Array of tabs
+ * @return 	array<array<int,string>>				Array of tabs
  */
 function conferenceorboothAttendeePrepareHead($object)
 {

htdocs/hrm/lib/hrm_evaluation.lib.php

@@ -3,6 +3,7 @@
  * Copyright (C) 2021 Greg Rastklan <greg.rastklan@atm-consulting.fr>
  * Copyright (C) 2021 Jean-Pascal BOUDET <jean-pascal.boudet@atm-consulting.fr>
  * Copyright (C) 2021 Grégory BLEMAND <gregory.blemand@atm-consulting.fr>
+ * Copyright (C) 2024		MDW							<mdeweerd@users.noreply.github.com>
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -28,7 +29,7 @@
  * Prepare array of tabs for Evaluation
  *
  * @param	Evaluation	$object		Evaluation
- * @return 	array					Array of tabs
+ * @return 	array<array<int,string>>	Array of tabs
  */
 function evaluationPrepareHead($object)
 {
@@ -129,7 +130,7 @@ function GetLegendSkills()
 }
 
 /**
- * @param  $obj  object  object need to handle
+ * @param  object $obj Object needed to be represented
  * @return string
  */
 function getRankOrderResults($obj)
@@ -163,8 +164,9 @@ function getRankOrderResults($obj)
 
 /**
  * Grouped rows with same ref in array
- * @param   array  $objects   all rows getted by sql
- * @return array |int
+ *
+ * @param   object[]  $objects   all rows retrieve from sql query
+ * @return	array<object>|int 			Object by groiup, -1 if error (empty or bad argument)
  */
 function getGroupedEval($objects)
 {