Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

Clean code

Browse Source
This commit is contained in:
ldestailleur
2025-03-09 22:42:59 +01:00
parent 3658bc20b6
commit 8c3b05d607
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
htdocs/core/boxes/box_external_rss.php
View File

@@ -4,7 +4,7 @@
* Copyright (C) 2004-2008 Laurent Destailleur <eldy@users.sourceforge.net>
* Copyright (C) 2005-2011 Regis Houssin <regis.houssin@inodbox.com>
* Copyright (C) 2015 Frederic France <frederic.france@free.fr>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -183,26 +183,27 @@ class box_external_rss extends ModeleBoxes
$description = str_replace("\r\n", "", $description);
$tooltip .= '<br>'.$description;
// Note: Escaping of value will be done by the showBox rendering method.
$this->info_box_contents[$line][0] = array(
'td' => 'class="left" width="16"',
'text' => img_picto('', 'rss'),
'url' => $href,
'tooltip' => dol_escape_htmltag($tooltip),
'tooltip' => $tooltip,
'target' => 'newrss',
);
$this->info_box_contents[$line][1] = array(
'td' => 'class="tdoverflowmax300"',
'text' => dol_escape_htmltag($title),
'text' => $title,
'url' => $href,
'tooltip' => dol_escape_htmltag($tooltip),
'tooltip' => $tooltip,
'maxlength' => 0,
'target' => 'newrss',
);
$this->info_box_contents[$line][2] = array(
'td' => 'class="right nowraponall"',
'text' => dol_escape_htmltag($date),
'text' => $date,
);
}
}

4
htdocs/core/boxes/modules_boxes.php
View File

@@ -341,7 +341,7 @@ class ModeleBoxes // Can't be abstract as it is instantiated to build "empty" bo
if (!empty($head['graph'])) {
$label .= ' <span class="opacitymedium fas fa-chart-bar"></span>';
}
$out .= '<input type="hidden" id="boxlabelentry'.$this->box_id.'" value="'.dol_escape_htmltag($label).'">';
$out .= '<input type="hidden" id="boxlabelentry'.$this->box_id.'" value="'.dolPrintHTMLForAttribute($label).'">';
$out .= '</div>';
}
@@ -388,7 +388,7 @@ class ModeleBoxes // Can't be abstract as it is instantiated to build "empty" bo
if (!empty($contents[$i][$j]['url']) && empty($contents[$i][$j]['logo'])) {
$out .= '<a href="'.$contents[$i][$j]['url'].'"';
if (!empty($tooltip)) {
$out .= ' title="'.dol_escape_htmltag($langs->trans("Show").' '.$tooltip, 1).'" class="classfortooltip"';
$out .= ' title="'.dolPrintHTMLForAttribute($langs->trans("Show").' '.$tooltip, 1).'" class="classfortooltip"';
}
//$out.= ' alt="'.$textwithnotags.'"'; // Pas de alt sur un "<a href>"
$out .= isset($contents[$i][$j]['target']) ? ' target="'.$contents[$i][$j]['target'].'"' : '';