Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
132,195 Commits 36 Branches 189 Tags
aee90023d3d009c9ca8d5eb1ac1f0a93395c80a0
Commit Graph

3784 Commits

Author SHA1 Message Date
Laurent Destailleur
aee90023d3 Merge branch 'develop' into fix_element_type_part_06 2024-03-16 16:11:56 +01:00
Laurent Destailleur
a247b474d7 Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence 
Fix some phan notifications with low occurrence
 2024-03-16 11:48:10 +01:00
MDW
1877dda1a4 Always return a value in dol_eval 2024-03-16 00:00:21 +01:00
MDW
b6f9df4ad3 Passing null to DOMDocument() is deprecated in PHP8.1 at the latest 2024-03-15 23:41:18 +01:00
Laurent Destailleur
0ee6fd6bad Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault 
Fix & enable PhanTypeMismatchDefault
 2024-03-15 15:44:30 +01:00
Laurent Destailleur
799ccf1a2f Merge pull request #28708 from atm-john/fix_element_type_part_05 
NEW : Factoring and Fix external module elementType limit - Part 05
 2024-03-15 15:29:03 +01:00
MDW
9a79e6b6d0 Fix PhanTypeMismatchDefault with typing hints 2024-03-15 13:26:23 +01:00
Laurent Destailleur
30037a5cba Fix: Test removalof one phan exception 2024-03-15 09:30:21 +01:00
Laurent Destailleur
1639bc83ca Merge pull request #28817 from frederic34/skiljob 
fix warnings
 2024-03-15 00:18:44 +01:00
MDW
a408288ba1 Fix & enable PhanPluginUnknownClosureParamType 
# Fix & enable PhanPluginUnknownClosureParamType

Typing of anonymous functions to fix this notice.
Optimised some minor things.
 2024-03-14 22:42:26 +01:00
Laurent Destailleur
e12faaa663 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2024-03-14 22:38:31 +01:00
Laurent Destailleur
c22a6219ec Debug v20 2024-03-14 16:40:06 +01:00
Laurent Destailleur
fb85f17ef4 FIX: Better error management in loading a website template 2024-03-14 12:09:35 +01:00
Frédéric FRANCE
23b0faeb44 Merge branch 'develop' into skiljob 2024-03-14 11:04:11 +01:00
Laurent Destailleur
ee214ae7fd Test to avoid not found method 2024-03-13 22:39:41 +01:00
Frédéric France
edb12bc63d Merge remote-tracking branch 'upstream/develop' into skiljob 2024-03-13 18:42:52 +01:00
Frédéric France
26fe76733c fix warnings 2024-03-13 18:20:41 +01:00
MDW
3ffa85eb49 Fix: Remove stray $i++ 2024-03-13 17:38:05 +01:00
John BOTELLA
94b943bc2f Merge branch 'fix_element_type_part_05' of github.com:atm-john/dolibarr into fix_element_type_part_06 2024-03-13 15:00:20 +01:00
John BOTELLA
f64e8c0689 Merge branch 'develop' of github.com:Dolibarr/dolibarr into fix_element_type_part_05 2024-03-13 14:42:43 +01:00
Laurent Destailleur
4afadf6dc4 Merge pull request #28804 from mdeweerd/fix/PhanPluginUnknownFunctionParamType 
Fix & enable PhanPluginUnknownFunctionParamType
 2024-03-13 14:31:18 +01:00
Laurent Destailleur
c3f28b8592 Merge pull request #28802 from mdeweerd/PhanPluginRedundantAssignment 
Fix PhanPluginRedundantAssignment
 2024-03-13 11:04:02 +01:00
MDW
1debf4f538 # Fix & enable PhanPluginPrintfNotPercent 
Fix PhanPluginPrintfNotPercent by setting format length to non 0 value.

Example of Notification message:

    'Format string "%0.10F" contains something that is not a percent sign, it will be treated as a format string '%0.10F' with padding of "0" and alignment of '' but no width. Use %% for a literal percent sign, or '%1$.10F' to be less ambiguous' .
 2024-03-13 10:42:13 +01:00
MDW
09a62365eb Fix PhanPluginUnknownFunctionParamType 
# Fix PhanPluginUnknownFunctionParamType

PHPdoc for $object was incorrect.
Also updated the return type and the parameter typing for $head
in complete_head_from_modules
 2024-03-13 10:08:12 +01:00
MDW
a57d0915a2 Fix PhanPluginRedundantAssignment 2024-03-13 01:03:53 +01:00
Laurent Destailleur
8c42ca11ef Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-12 21:24:34 +01:00
Laurent Destailleur
9807ed32e8 Update functions.lib.php 2024-03-12 21:09:23 +01:00
Laurent Destailleur
bf954e9cd7 Fix for compatibility 2024-03-12 21:04:20 +01:00
MDW
29b8d0db84 Fix: Duplicate test on "shipping", replaced duplicate with delivery_note 
# Fix: Duplicate test on "shipping", replaced duplicate with delivery_note

The second test on "shipping" was without effect but as the module was set to
"expedition_bon", I modified the test to delivery_note and put it closer to
the test on "shipping"
 2024-03-12 19:05:15 +01:00
Laurent Destailleur
cc6fbef64d Update functions.lib.php 2024-03-12 14:44:48 +01:00
Laurent Destailleur
53c3406d11 Merge branch 'develop' into fix_element_type_part_05 2024-03-12 14:22:25 +01:00
Francis Appels
7ff68a5819 Fix shipping is not a delivery_note (sub module of shipping) 2024-03-12 11:07:18 +01:00
Laurent Destailleur
dcca7cc3f6 Better support for MAIN_OPTIMIZEFORTEXTBROWSER 2024-03-12 02:54:05 +01:00
Laurent Destailleur
56950673b8 Better support for MAIN_OPTIMIZEFORTEXTBROWSER 2024-03-12 02:41:47 +01:00
John BOTELLA
9aaae61c9a Fix var 2024-03-11 16:49:46 +01:00
Laurent Destailleur
93638f3980 Merge pull request #28667 from atm-john/fix_element_type_part_03 
NEW : Factoring and Fix external module elementType limit - Part 03
 2024-03-11 16:19:00 +01:00
John BOTELLA
84ac33e1f5 Merge branch 'develop' of github.com:Dolibarr/dolibarr into fix_element_type_part_06 2024-03-11 16:14:28 +01:00
Laurent Destailleur
41078a9a46 Merge branch 'develop' into test/security_dol_eval_ob_cleanup_on_exception 2024-03-11 14:57:33 +01:00
John BOTELLA
ed6874154d Merge branch 'develop' into fix_element_type_part_05 2024-03-11 14:33:48 +01:00
Laurent Destailleur
0f2121e3ba Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 13:46:08 +01:00
Laurent Destailleur
ff0d147847 Merge branch 'develop' into test/security_dol_eval_ob_cleanup_on_exception 2024-03-11 12:48:31 +01:00
Laurent Destailleur
a327d39062 Fix warning 2024-03-11 11:39:51 +01:00
MDW
101d56a2c1 Fix: Ob buffer cleanup on exception 
# Fix: Ob buffer cleanup on exception

The OB buffer capture was incorrectly cleaned up on exception.
This fixes that.

Also modified the SecurityTest to enable running it standalone
 2024-03-10 15:17:58 +01:00
Laurent Destailleur
429476e293 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-10 01:53:32 +01:00
MDW
37afba949e Fix most PhanTypeMismatchDimAssignment notices (#28739) 
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice

* Fix: Initialise array for code in somme

* Qual: Update type hint for  argument in _Set_Format

* Qual: Update type hint for childtables

* Qual: Add typing to attributes

* Qual: Add typing for _msgContent

* Qual: Suppress PhanTypeMismatchDimAssignment

* Qual: Add typing for liste

* Qual: Add typing to fields

* Qual: Add typing hint for $objMod

* Qual: Modify assignment of array with bool keys for phan typing

Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
  [1] =>
  string(3) "yes"
  [0] =>
  string(2) "no"
}
```

* Qual: Add typing hint to indicate value is not null

* Force non-null type on $paramname

* Qual: Add typing hint to getCats()

* Update inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-03-10 01:53:04 +01:00
Laurent Destailleur
28df0ba1ab Fix doc 2024-03-10 01:49:56 +01:00
MDW
c95bab2818 Qual: Add check on addExtraField type argument (#28738) 
* Qual: Add check on addExtraField type argument

# Qual: Add check on addExtraField type argument

Added a check on the type argument for addExtraField

* Qual: Update phan ignore with more specific name
 2024-03-10 01:46:10 +01:00
MDW
0b19aa415c Fix: Initialise array before assigning values (#28728) 
* Qual: Enable PhanUndeclaredVariableDim

# Qual: Enable PhanUndeclaredVariableDim

The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Qual: Add type hint to array to avoid phan notification

* Qual: Add type hint to array to avoid phan notification

* Qual: Enable PhanParamSpecial1 (all resolved)

* Qual: Ignore false PhanTypeArraySuspiciousNullable

* Qual: Improve typing to fix PhanTypeArraySuspicious

* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array

* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Enable phan messages that no longer appear

* Qual: Exclude phan stubs from codesniffer ruleset
 2024-03-09 16:32:02 +01:00
Laurent Destailleur
abc57a767b Merge branch 'develop' into fix_element_type_part_05 2024-03-09 15:23:23 +01:00
thibdrev
2cb4d40e5e qual: phan for functions.lib.php (#28655) 
* Update card.php

* Update functions.lib.php

* Update card.php

* Update releve.php

* Update card-rec.php

* Update card.php

* Update prelevement.php

* Update card.php

* Update index.php

* Update index.php

* Update html.form.class.php

* Update card.php

* Update conferenceorbooth_card.php

* Update conferenceorbooth_contact.php

* Update conferenceorbooth_document.php

* Update conferenceorbooth_list.php

* Update conferenceorboothattendee_card.php

* Update conferenceorboothattendee_list.php

* Update shipment.php

* Update card.php

* Update card-rec.php

* Update card.php

* Update card.php

* Update document.php

* Update card.php

* Update comment.php

* Update element.php

* Update ganttview.php

* Update tasks.php

* Update comment.php

* Update contact.php

* Update document.php

* Update note.php

* Update task.php

* Update time.php

* Update card.php

* Update card.php

* Update bank.php

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-03-09 01:49:07 +01:00