2
0
forked from Wavyzz/dolibarr
Commit Graph

130373 Commits

Author SHA1 Message Date
thibdrev
db2fc174cd qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28364)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array<int, float> of property Paiement::$multicurrency_tx is not covariant with PHPDoc type float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array<int, string> of property Paiement::$multicurrency_code is not covariant with PHPDoc type string of overridden property CommonObject::$multicurrency_code.
2024-02-23 13:40:22 +01:00
thibdrev
77ae6888ff qual: phpstan for $user_valid (#28362)
* Update commande.class.php

htdocs/commande/class/commande.class.php	248	PHPDoc type int of property Commande::$user_valid is not covariant with PHPDoc type User of overridden property CommonObject::$user_valid.

* Update facture.class.php

htdocs/compta/facture/class/facture.class.php	129	PHPDoc type int of property Facture::$user_valid is not covariant with PHPDoc type User of overridden property CommonObject::$user_valid.
2024-02-23 13:39:49 +01:00
MDW
2cd1a1a303 Fix: Add parentheses to fix expression (#28365)
* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'

* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'

* Fix: Add parentheses to fix expression

# Fix: Add parentheses to fix expression

The priority of == is higher than bitwise & which is not what the
expression supposes.
(See https://www.php.net/manual/en/language.operators.precedence.php).

Detected as 'PhanPluginDuplicateExpressionBinaryOp: Both sides of the binary operator == are the same: 1' because of '1 == 1'
2024-02-23 13:39:17 +01:00
William Mead
70a061d0ce Qual PHPStan Facture class (#28371)
* Fixed usage of deprecated $user_author

* Deleted unused properties

* Cleaned PHPDoc
2024-02-23 13:38:28 +01:00
Laurent Destailleur
ad662c468f Fix sql with field name "desc" 2024-02-22 19:52:24 +01:00
Laurent Destailleur
f35e55030e Fix sql with field name "desc" 2024-02-22 19:49:43 +01:00
Laurent Destailleur
007b2bf758 Doygen 2024-02-22 19:29:31 +01:00
Laurent Destailleur
260505e2aa Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 19:27:03 +01:00
Laurent Destailleur
71dc610c25 Doc 2024-02-22 19:26:47 +01:00
thibdrev
132e98a4c7 qual: phpstan for CommonObject->origin (#28361)
htdocs/commande/class/commande.class.php	538	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/commande/class/commande.class.php	675	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/compta/facture/class/facture.class.php	2859	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3378	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3696	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	2326	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/expedition/class/expedition.class.php	2487	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/fourn/class/fournisseur.commande.class.php	1283	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.commande.class.php	2278	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1858	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1999	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/commande/dispatch.php	435	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	482	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	489	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/reception/class/reception.class.php	582	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1081	Property CommonObject::$origin (string) does not accept null.
htdocs/reception/class/reception.class.php	1674	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1833	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1967	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/takepos/invoice.php	332	Property CommonObject::$origin (string) does not accept Facture.
htdocs/takepos/invoice.php	336	Property CommonObject::$origin (string) does not accept Facture.
2024-02-22 19:25:01 +01:00
thibdrev
bb178dc8ab qual: phpstan for htdocs/takepos/invoice.php (#28360)
htdocs/takepos/invoice.php	284	Property Paiement::$pos_change (float) does not accept string.
2024-02-22 19:18:00 +01:00
Laurent Destailleur
c99906db11 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 19:16:49 +01:00
Laurent Destailleur
8342b823c4 Fix $ventil warning 2024-02-22 19:16:32 +01:00
thibdrev
87a5ca7756 qual: phpstan for $fk_unit (#28359)
* Update bom.class.php

* Update commonobjectline.class.php

* Update product.class.php

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs
2024-02-22 19:14:31 +01:00
Laurent Destailleur
838c748fae Reduce variable parts into website template so risk of git conflict is
lower
2024-02-22 17:30:54 +01:00
Laurent Destailleur
82dd321662 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 13:28:40 +01:00
Laurent Destailleur
637ffa837f Clean code 2024-02-22 13:28:18 +01:00
thibdrev
999af4951b qual: phpstan - various "$hidden (bool) does not accept string." (#28350)
* Update modWebsite.class.php

* Update DolibarrModules.class.php

* Update modCron.class.php

* Update modSocialNetworks.class.php

* qual: phpstan for htdocs/core/modules/modCollab.class.php

htdocs/core/modules/modCollab.class.php	68	Property DolibarrModules::$hidden (bool) does not accept string.
2024-02-22 13:27:04 +01:00
MDW
f1f516f54c NEW: Global constant for deprecated module mapping (#28348)
* Qual: Add another deprecated module mapping

* NEW: Global constant for deprecated module mapping
2024-02-22 13:23:39 +01:00
thibdrev
2b4bc3b4bc qual: phpstan for htdocs/resource/class/dolresource.class.php (#28352)
htdocs/resource/class/dolresource.class.php	723	Property Dolresource::$busy (int) does not accept string.

htdocs/resource/class/dolresource.class.php	726	Property Dolresource::$mandatory (int) does not accept string.
2024-02-22 13:22:24 +01:00
thibdrev
009a4856b3 qual: phpstan - various fixes (#28351)
* qual: phpstan for htdocs/compta/tva/class/paymentvat.class.php

htdocs/compta/tva/class/paymentvat.class.php	540	Property CommonObject::$tms (int) does not accept string.

* qual: phpstan - various "$enabled (int) does not accept bool."

htdocs/core/boxes/box_actions.php	54	Property box_actions::$enabled (int) does not accept bool.

htdocs/core/boxes/box_actions_future.php	54	Property box_actions_future::$enabled (int) does not accept bool.

htdocs/core/boxes/box_activity.php	53	Property box_activity::$enabled (int) does not accept string.

* qual: phpstan for htdocs/core/boxes/box_activity.php

htdocs/core/boxes/box_activity.php	53	Property box_activity::$enabled (int) does not accept string.

* qual: phpstan for htdocs/core/modules/modTakePos.class.php

htdocs/core/modules/modTakePos.class.php	284	Property Societe::$code_client (string) does not accept int.

htdocs/core/modules/modTakePos.class.php	285	Property Societe::$code_fournisseur (string) does not accept int.
2024-02-22 13:22:06 +01:00
Laurent Destailleur
757abcfaae Fix warning 2024-02-22 13:20:00 +01:00
Laurent Destailleur
8ba8b62180 Standardize field name 2024-02-22 13:11:32 +01:00
Laurent Destailleur
01e82a94b8 Fix phpstan 2024-02-22 12:46:57 +01:00
Laurent Destailleur
23492676b0 Removed definitely modelpdf (replaced with model_pdf) 2024-02-22 12:30:35 +01:00
Laurent Destailleur
739efc8086 Clean code 2024-02-22 12:23:12 +01:00
Laurent Destailleur
95fe95056d Clean deprecation 2024-02-22 11:57:38 +01:00
Laurent Destailleur
db112104e8 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 11:47:23 +01:00
Laurent Destailleur
6bf8bd3920 Fix ->ventil property 2024-02-22 11:47:00 +01:00
Eric
9e1cb4c88a nom (deprecated) -> name (#28345) 2024-02-22 11:33:40 +01:00
Laurent Destailleur
ba204f2787 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-02-22 11:33:05 +01:00
Laurent Destailleur
07a5e05c17 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 11:32:45 +01:00
Olivier ANDRADE SANCHEZ
1fe93ab55e [FIX] Add fetch_optionnals() to BOMLine for api calls (#28349) 2024-02-22 11:32:30 +01:00
Laurent Destailleur
5167fe2a62 Fix complete for #28349 2024-02-22 11:32:21 +01:00
Laurent Destailleur
9ef57501a2 Fix var_dump 2024-02-22 11:22:43 +01:00
MDW
d5d7003f08 Qual: Add test to validate module_names (#28340)
* Qual: Add test to validate module_names

# Qual: Add test to validate module_names

This ensures that all explitly tested module names appear in the reference list.
Displays messages when the module_name is deprecated

* Update CodingPhpTest.php

* Update CodingPhpTest.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-22 02:54:37 +01:00
MDW
5faf933d26 #FIX modulenames (#28338)
* Fix: modulename

* Fix: modulename
2024-02-22 02:45:36 +01:00
Laurent Destailleur
ae84bf8752 Fix error if result empty 2024-02-22 02:36:21 +01:00
Laurent Destailleur
c5b0a13557 Fix warning 2024-02-22 02:27:19 +01:00
Laurent Destailleur
9d48dcbd3d Fix phpstan 2024-02-22 01:32:55 +01:00
Laurent Destailleur
841647243c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 00:19:28 +01:00
Laurent Destailleur
0505f8e563 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 00:19:19 +01:00
Laurent Destailleur
2807c9410f Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 00:19:19 +01:00
Laurent Destailleur
32d35d5443 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-22 00:18:42 +01:00
Laurent Destailleur
9874d008aa Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-22 00:16:59 +01:00
Laurent Destailleur
1f129feed8 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-02-22 00:16:36 +01:00
Laurent Destailleur
88da45d9dd Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-02-22 00:16:14 +01:00
Laurent Destailleur
a76eafa0d4 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2024-02-22 00:15:35 +01:00
Laurent Destailleur
8c2a910a94 Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2024-02-22 00:13:59 +01:00
Laurent Destailleur
f7e8725406 Clean code 2024-02-22 00:12:33 +01:00