Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-02-08 17:02:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

clean code (#35683)

Browse Source 
* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
This commit is contained in:
Frédéric FRANCE
2025-10-08 21:32:49 +02:00
committed by GitHub
parent 8e3a185af5
commit 2ed9f1ea98
2 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dev/build/phpstan/phpstan-baseline.neon
View File

@@ -1182,12 +1182,6 @@ parameters:
count: 1
path: ../../../htdocs/ai/admin/setup.php
-
message: '#^Call to function is_object\(\) with ActionComm\|Adherent\|Commande\|CommandeFournisseur\|Contact\|Contrat\|Expedition\|ExpenseReport\|Facture\|FactureFournisseur\|Fichinter\|Mo\|Product\|Project\|Propal\|Task will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: ../../../htdocs/api/class/api_documents.class.php
-
message: '#^Variable \$modulepart in empty\(\) always exists and is not falsy\.$#'
identifier: empty.variable

26
htdocs/api/class/api_documents.class.php
View File

@@ -907,19 +907,18 @@ class Documents extends DolibarrApi
throw new RestException(500, 'Modulepart '.$modulepart.' not implemented yet.');
}
if (is_object($object)) {
if ($fetchbyid) {
// @phan-suppress-next-line PhanPluginSuspiciousParamPosition
$result = $object->fetch((int) $ref);
} else {
$result = $object->fetch(0, $ref);
}
// at this step $object is always an object
if ($fetchbyid) {
// @phan-suppress-next-line PhanPluginSuspiciousParamPosition
$result = $object->fetch((int) $ref);
} else {
$result = $object->fetch(0, $ref);
}
if ($result == 0) {
throw new RestException(404, "Object with ref '".$ref."' was not found.");
} elseif ($result < 0) {
throw new RestException(500, 'Error while fetching object: '.$object->error);
}
if ($result == 0) {
throw new RestException(404, "Object with ref '".$ref."' was not found.");
} elseif ($result < 0) {
throw new RestException(500, 'Error while fetching object: '.$object->error);
}
if (!($object->id > 0)) {
@@ -1056,7 +1055,8 @@ class Documents extends DolibarrApi
}
$moreinfo = array('note_private' => 'File uploaded using API /documents from IP '.getUserRemoteIP());
if (!empty($object) && is_object($object) && $object->id > 0) {
// $object may be null
if (is_object($object) && $object->id > 0) {
$moreinfo['src_object_type'] = $object->table_element;
$moreinfo['src_object_id'] = $object->id;
}