Commit Graph

130515 Commits

Author SHA1 Message Date
Lamrani Abdel
0ca145bfd0 fix ref and verify date and time 2024-02-27 17:27:49 +01:00
Lamrani Abdel
a6db30f1df fix ref and verify date and time 2024-02-27 16:53:59 +01:00
Frédéric FRANCE
148d6d4c39 add arrayfields in parameters for hook printFieldPreListTitle (#28428)
* add search member status if column not displayed

* Update list.php
2024-02-27 00:15:57 +01:00
Frédéric FRANCE
cadbb0cea1 fix phpstan (#28445)
Default value of the parameter #9 $fk_unit (string) of method BOM::addLine() is incompatible with type int.
2024-02-27 00:14:53 +01:00
Frédéric FRANCE
02ec0bcd74 fix phan (#28444) 2024-02-27 00:14:34 +01:00
MDW
1c3a035ae5 Qual: New Phan plugin for testing that argument matches regex (#28424)
* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Update config.php

* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Report scalar values (see null, etc)

* Qual: Ignore false Phan Notification

* Qual: Ignore false Phan Notification

* Qual: Fix Phan needs specific message keys for coloring.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-26 23:10:16 +01:00
Frédéric FRANCE
1d1e6ac562 fix typo (#28430) 2024-02-26 23:04:07 +01:00
Frédéric FRANCE
ac328d6acb fix phpstan (#28432)
Default value of the parameter #6 $noreplace (int) of function GETPOST() is incompatible with type string.
2024-02-26 23:03:42 +01:00
Frédéric FRANCE
84b01dc1f8 fix phpstan (#28433)
Default value of the parameter #2 $mesgarray (string) of function get_htmloutput_mesg() is incompatible with type array<string>.
2024-02-26 23:02:53 +01:00
Anthony Berton
f0dc1358f9 Order list det change to eprimental (#28438)
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
2024-02-26 23:01:08 +01:00
Frédéric FRANCE
96a727d1f0 fix phpstan (#28434)
Default value of the parameter #5 $id (string) of function print_fiche_titre() is incompatible with type int.
2024-02-26 23:00:28 +01:00
Frédéric FRANCE
f0209f1b66 fix phpstan (#28441) 2024-02-26 22:54:32 +01:00
Frédéric FRANCE
8262fb9605 fix phpstan (#28440) 2024-02-26 22:53:21 +01:00
Frédéric FRANCE
1692dad347 fix #28431 (#28439) 2024-02-26 22:52:09 +01:00
Frédéric FRANCE
e969ddc386 fix phpstan (#28436) 2024-02-26 22:34:17 +01:00
Laurent Destailleur
d4c1896552 Fix edit website css content 2024-02-26 21:47:12 +01:00
Laurent Destailleur
017eb28ad3 Work on custom report 2024-02-26 20:39:46 +01:00
Laurent Destailleur
b4ea234b75 Work on customreports 2024-02-26 20:11:55 +01:00
Laurent Destailleur
5fc6dbdf2f Fix avoid false positive of injection 2024-02-26 19:59:42 +01:00
Laurent Destailleur
71374be506 Comment 2024-02-26 19:14:00 +01:00
Laurent Destailleur
817b62868e Doc 2024-02-26 19:08:00 +01:00
Laurent Destailleur
c1a81c39b7 Work on custom report 2024-02-26 18:06:35 +01:00
Laurent Destailleur
b3a2d17fe5 FIX #28429 2024-02-26 16:35:01 +01:00
Laurent Destailleur
182d5eba5b Fix warnings 2024-02-26 15:15:08 +01:00
Laurent Destailleur
fa2cfb97b1 Fix bad parameter for GETPOST 2024-02-26 15:02:39 +01:00
Laurent Destailleur
1141cdca18 Link to whatsapp 2024-02-26 14:16:24 +01:00
Laurent Destailleur
3e801c94ff NEW Look and field: The operator 'or' on category filter visible only
when 2+ categories
2024-02-26 13:43:34 +01:00
Laurent Destailleur
7d4334a353 Fix when first label is '0' 2024-02-25 23:58:37 +01:00
Laurent Destailleur
8322a4e850 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-25 23:49:57 +01:00
Laurent Destailleur
9b8d39267a Debug v20 2024-02-25 23:49:20 +01:00
MDW
d8e12140e0 Fix: Handle facture modulepart depr + optimise (#28418)
# Fix: Handle facture modulepart depr + optimise

Add a case for 'facture' to 'invoice' conversion for the 'modulepart'
(issue seen when introducing DolDeprationHandler).
Use elseif for optimisation.
2024-02-25 22:16:32 +01:00
Frédéric FRANCE
991b39c8a0 fix phpstan (#28422) 2024-02-25 22:14:55 +01:00
MDW
3d3ef247c5 Fix: Replace deprecated php aliases with actual functions (#28419)
* Fix: Handle facture modulepart depr + optimise

# Fix: Handle facture modulepart depr + optimise

Add a case for 'facture' to 'invoice' conversion for the 'modulepart'
(issue seen when introducing DolDeprationHandler).
Use elseif for optimisation.

* Fix: Replace deprecated php aliases with actual functions

# Fix: Replace deprecated php aliases with actual functions

Replacements of join with implode.

* Fix: Replace deprecated php aliases with actual functions

# Fix: Replace deprecated php aliases with actual functions

Replacements of join with implode.

* Fix: Replace deprecated php aliases with actual functions

# Fix: Replace deprecated php aliases with actual functions

Replacements of join with implode.
2024-02-25 22:14:39 +01:00
Frédéric FRANCE
0de5807423 fix phpstan (#28416)
Default value of the parameter #8 $filterkey (string) of method FormResource::select_resource_list() is incompatible with type array.
2024-02-25 22:14:02 +01:00
Anthony Berton
6ab63d4f33 look and feel yes no (#28421)
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
2024-02-25 22:12:32 +01:00
Frédéric FRANCE
aa25dc5bdc fix phpstan (#28417)
Default value of the parameter #2 $array_options (int) of method Delivery::update_line() is incompatible with type array.
2024-02-25 22:11:44 +01:00
MDW
0d60041d8f Qual: Add custom phan plugin to detect var_dump (#28420)
# Qual: Add custom phan plugin to detect var_dump

This adds a custom plugin to detect the presence of var_dump.

Also disable a standard plugin in the extended configuration
(avoid reporting suggestions to add typing to the function
definitions (/declarations).
2024-02-25 22:11:25 +01:00
Frédéric FRANCE
75131fcc8f fix phpstan (#28414)
Default value of the parameter #7 $save_lastsearch_value (string) of method Categorie::getNomUrl() is incompatible with type int.
2024-02-25 22:10:38 +01:00
Frédéric FRANCE
7374dd9c2d fix phpstan (#28412)
Property CommonObject::$shipping_method_id (int) does not accept string.
2024-02-25 22:10:04 +01:00
Frédéric FRANCE
a1d90ada65 NEW Can setup phone mobile for the main company (#28410)
* setup phone mobile for mysoc

* clean code
2024-02-25 22:09:50 +01:00
Frédéric FRANCE
3f8376c2b8 fix odt templates lost (#28411) 2024-02-25 22:08:45 +01:00
MDW
acd8168cb6 Fix: Fix var_dump checker (#28226)
* Fix: Fix var_dump checker

# Fix: Fix var_dump checker

The core issue was that in PHP whitespace includes newlines by default, the m modifier
is needed to not match multilines.

* Fix: Allow multiple var_dumps on single comment line, refactor

# Fix: Allow multiple var_dumps on single comment line, refactor

Updated the regex to not match a var_dump preceeded with a comment
somewhere on the line.

Refactored var_dump check in dedicated method.

* Qual: Test the test function !

# Qual: Test the test function !

Test that the test function detecting var_dump does detect them.

* Qual: CodingPhpTest - remove comments from file before checking

# Qual: CodingPhpTest - remove comments from file before checking

This helps remove false positives and may have a positive impact on performance.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-25 22:08:07 +01:00
Laurent Destailleur
181c70f116 Do not use mysql port on command line if value is 0 2024-02-25 21:53:35 +01:00
Laurent Destailleur
08a61c542a Restore dolPrintLabel 2024-02-25 20:53:42 +01:00
Laurent Destailleur
16b2cf2880 Fix creation of emailing 2024-02-25 20:41:58 +01:00
Laurent Destailleur
31cef09780 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-25 19:07:35 +01:00
Laurent Destailleur
c171ce2065 Fix bad function 2024-02-25 19:04:05 +01:00
Laurent Destailleur
87d25869ac Fix lost lines 2024-02-25 18:55:22 +01:00
Laurent Destailleur
0737d323b7 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-25 18:37:35 +01:00
Laurent Destailleur
2db3dc0eef Fix output for phpphan 2024-02-25 18:36:40 +01:00