Commit Graph

9579 Commits

Author SHA1 Message Date
Laurent Destailleur
793e77bc5f Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2024-10-14 19:21:00 +02:00
Alexandre SPANGARO
4a91c2c734 NEW Accountancy - Add general account on thirdparty - Code supplier part (#31318)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

* NEW Accountancy - Add general account on thirdparty - Code supplier part

* Fix phan

* Fix phan

* Fix phan

* Use list of account instead of  simple input

* Use list of account instead of simple input

* Tabs

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-14 12:05:07 +02:00
thomas-Ngr
70a453a5c2 FIX: substitutions THIRDPARTY_XXX are not available for actioncomm reminders (#31385) 2024-10-14 11:57:55 +02:00
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308)
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
nateogroup-antoine
66ba46c04c Propal informations not updated after adding a line with MAIN_DISABLE_PDF_AUTOUPDATE set to 1 (#31332)
* Update card.php

When a line is added to a Propal with the MAIN_DISABLE_PDF_AUTOUPDATE variable set to 0, the object is not reloaded, so the weight and amount are not updated when the new line is displayed.

* Update card.php
2024-10-13 21:00:19 +02:00
Laurent Destailleur
e46553079a FIX CSS 2024-10-13 18:37:21 +02:00
Laurent Destailleur
8b8c6bba3d FIX CSS 2024-10-13 18:36:32 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
Alexandre SPANGARO
6fe1adec7d NEW Accountancy - Add general account on thirdparty - Code customer part (#31294)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-09 01:51:12 +02:00
jyhere
5f83eb2552 FIX : shippings $file_list is always empty because path is incorrect (#31299) 2024-10-07 14:15:02 +02:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
Laurent Destailleur
9d79175638 Clean code 2024-10-04 19:25:02 +02:00
Laurent Destailleur
ab5575e0c2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-04 18:51:00 +02:00
Laurent Destailleur
fe6a50ef11 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-04 18:46:27 +02:00
HENRY Florian
934d291194 fix: action/card.php do not display priority field if hidden conf not activated (#31277) 2024-10-04 18:45:54 +02:00
Laurent Destailleur
d24069d5e2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:35:33 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212)
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 19:40:34 +02:00
John BOTELLA
a333af2ceb fix missing token for links (#31225) 2024-10-03 16:19:04 +02:00
Laurent Destailleur
805555a059 Fix autoset end date on event creation 2024-10-01 12:55:12 +02:00
Laurent Destailleur
08a670a32c Fix filter on type of event 2024-10-01 12:37:03 +02:00
Laurent Destailleur
072b3e7022 Fix empty value on combo to select types 2024-10-01 12:29:59 +02:00
Frédéric FRANCE
60860aa781 add phpdoc (#31196) 2024-09-30 10:08:03 +02:00
MDW
8236aed22f Qual: Fix phan notices (#31193)
# Qual: Fix phan notices

Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
a760fc0092 fix phpstan (#31189)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 21:51:51 +02:00
MDW
93005b2c08 Qual: Add centpecent to codespell, fix css (#31178)
# Qual: Add centpecent to codespell, fix css

Try to prevent misspelling in css by adding centpecent.
Fix corresponding cases

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 13:09:09 +02:00
Laurent Destailleur
862ce222d9 Close #31001 2024-09-28 18:18:25 +02:00
Frédéric FRANCE
1e1e60be26 add phpdoc (#31174)
* add phpdoc

* add phpdoc

* add phpdoc
2024-09-28 12:11:03 +02:00
Frédéric FRANCE
340bd12ee7 add php doc (#31173)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc
2024-09-28 11:15:38 +02:00
MDW
c62e015410 Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl (#31087)
# Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl

Fix phan notices in these files

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-26 23:01:02 +02:00
Mohamed DAOUD
797957dfd3 work on date edit event (#31112)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-26 22:46:50 +02:00
Frédéric FRANCE
efdb2f8a51 add phpdoc (#31148) 2024-09-26 22:29:55 +02:00
UltraViolet33
b2aafb37f3 Fix agenda event type label instead of event type code on actionComm card (#31106)
* Fix display agenda event type label instead of event type code when event type code has no translation

In a ActionComm card, if we use agenda event types, the type of event displayed is the event code if this event code has no translation.
Now, if there is no translation, the label of the event type is displayed instead of the code.

* fix for PHPStan

* fix for PHPStan

* fix for PHPStan

* fix for PHPStan

---------

Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-26 17:47:49 +02:00
Laurent Destailleur
6b72c665af Fix phan warning 2024-09-26 16:38:23 +02:00
Laurent Destailleur
1aae82898c Fix error management 2024-09-26 12:46:08 +02:00
Laurent Destailleur
7c2e2bfbea Fix error management 2024-09-26 12:44:38 +02:00
Laurent Destailleur
c0a63855f3 QUAL: Edition of currency is shared in a common tpl file 2024-09-26 12:22:03 +02:00
Laurent Destailleur
e78a879293 Look and feel v21 2024-09-26 11:30:02 +02:00
Noé Cendrier
22729516fe NEW Add mode Customer price + level price (#31091)
* NEW: customer price and level price together

* NEW: translation

* FIX: If a price per customer exist

* FIX: do not use default price if the customer price and level price option is active

* Don't display the price level amount if the customer price is known

* FIX: double check and php cs correction

* FIX: vatrate call

* FIX: get_htmloutput_msg call

---------

Co-authored-by: Mélina JOUM <melina.joum@altairis.fr>
2024-09-25 23:18:16 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Frédéric FRANCE
a94cff63a7 fix phpstan (#31102)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-25 22:21:31 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9 fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
MDW
7b4c4d772c Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related (#31086)
* Qual: Fix Array of tabs typing hints

# Qual: Fix Array of tabs typing hints

Fixed same typing hints accross several files

* Qual: Fix pdf.lib.php, project.lib.php and related files

# Qual: Fix pdf.lib.php, project.lib.php and related files

Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process

* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card

* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
2024-09-23 00:37:30 +02:00
Frédéric FRANCE
13d4d96dfc fix phpstan (#31061)
* fix phpstan

* fix phpstan
2024-09-20 17:25:39 +02:00
Laurent Destailleur
84e5f5e7b4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-20 02:51:59 +02:00
Laurent Destailleur
401c9898bb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-20 02:46:03 +02:00
Laurent Destailleur
87adbbb769 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-20 02:39:55 +02:00
MaximilienR-easya
7308b03b1d autofill datef to now when we create an event with a status set to 100% (#31036) 2024-09-20 00:28:35 +02:00