Wavyzz/dolibarr
2
0
Fork 1
mirror of https://github.com/Dolibarr/dolibarr.git synced 2026-01-23 17:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity
145,227 Commits 38 Branches 191 Tags
0de4e225fb702681d7e9d19ecda1c1da170a357e
Commit Graph

9579 Commits

Author SHA1 Message Date
Laurent Destailleur
5eff8e366e Debug v21 2024-09-18 16:14:45 +02:00
MDW
099dbd9c1e Qual: Fix notices for htdocs/admin/* (#30982) 
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
 2024-09-18 03:27:25 +02:00
HENRY Florian
126dc77ef3 fix: add missing hook in propal and invoice (contact and document tabs) (#30518) 
* add missing hook in propal contact and document

* add missing hook in propal contact and document

* add missing hook in propal and invoice (contact and document)

* add missing hook in propal and invoice (contact and document)

* add missing hook in propal and invoice (contact and document)

* review: change inithook place
 2024-09-18 03:03:05 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-18 02:45:54 +02:00
Laurent Destailleur
e09fa82deb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-17 02:51:19 +02:00
Laurent Destailleur
65edbd5f9f FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:50:47 +02:00
Laurent Destailleur
b180beba04 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 12:03:13 +02:00
Laurent Destailleur
697bf01970 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-16 12:01:04 +02:00
Laurent Destailleur
b0fe6a0b1f Merge v18 2024-09-16 11:56:23 +02:00
MDW
115627a054 Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957) 
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
 2024-09-16 01:49:38 +02:00
Laurent Destailleur
26ba862540 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 02:45:04 +02:00
Laurent Destailleur
da5d4f0f67 Debug v20 2024-09-13 15:58:26 +02:00
William Mead
4cd82df73c FIX late propal search option (v18+) (#30687) 
* Fixed search late propal. Added search late propal checkbox.

* Removed late date alert checkbox
 2024-09-13 04:07:24 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940) 
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
 2024-09-13 03:09:23 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925) 
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
 2024-09-12 21:16:42 +02:00
Laurent Destailleur
b1ee18864f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 01:43:43 +02:00
Laurent Destailleur
eef52208ea Debug v20 2024-09-11 17:03:00 +02:00
Laurent Destailleur
bbf6ad202c Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-10 16:29:02 +02:00
Laurent Destailleur
f2c5749fc6 Fix bad parameters 2024-09-10 02:50:20 +02:00
Lucas Marcouiller
bec9134080 New use of multi button action on propal card (#30900) 
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
 2024-09-10 00:58:17 +02:00
Laurent Destailleur
7a52dd8547 Debug v20 Fix token 2024-09-06 16:33:28 +02:00
Laurent Destailleur
045f99192b Debug v20 Fix token 2024-09-06 16:31:48 +02:00
Laurent Destailleur
aebcc76df8 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-06 14:03:05 +02:00
Frédéric FRANCE
f29e9e760f fix phpstan (#30861) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-06 14:02:53 +02:00
Laurent Destailleur
43f42d08ad Fix warning 2024-09-06 14:01:55 +02:00
Laurent Destailleur
40f0173678 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2024-09-05 22:44:57 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649) 
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-05 16:05:37 +02:00
Laurent Destailleur
6e2d7ccd99 Debug v20 - Fix label 2024-09-05 15:28:49 +02:00
Laurent Destailleur
bee59df23c Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-05 15:02:30 +02:00
Laurent Destailleur
ea599f1264 Debug v20 Fix can't create an event 2024-09-05 14:58:56 +02:00
William Mead
a57635d701 Qual isolate PropaleLigne class to separate file (#30838) 
* Moved PropaleLigne class to separate file

* Removed unnecessary requires

* Updated PHPDoc

* Fixed PHPDoc

* Fixed PHPDoc

* Update propaleligne.class.php

* Fixed PHPDoc

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-05 12:48:31 +02:00
ptibogxiv
b2762be57d Update api_agendaevents.class.php with pagination (#30820) 
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-04 23:14:55 +02:00
Laurent Destailleur
2009c6f09a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-31 17:30:32 +02:00
Laurent Destailleur
b8dadd4b6a Debug v20 Fix missing test on permissions 2024-08-31 17:23:13 +02:00
Laurent Destailleur
2c28d039e2 Fix test on permissions 2024-08-31 16:26:08 +02:00
MDW
c496e84916 Qual: Fix phan issues related to getNextValue() notices (#30747) 
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix some phan typing related to getNextValue()

# Qual: Fix some phan typing related to getNextValue()

This fixes a few typings in relation to getNextValue().

* Update phan baseline

* PHPDoc: set arguments as nullable (+update array types)

* Improve PHPDoc

* Force toselect type to int[]

* Enable all phan notices on actions_massactions.inc.php

* Test was wrong, can not count when it's not an array

* Update baseline

* Remove ignore for notice that no longer exists

* Update baseline

* Fix format argument

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-29 15:01:42 +02:00
Laurent Destailleur
53c8851f2c Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 05:16:02 +02:00
MDW
56e0bba970 Qual: Disable global CommonObject $obj type (phan) (#30750) 
* Qual: Disable global CommonObject $obj type (phan)

# Qual: Disable global CommonObject $obj type (phan)

This removes the global typing hint for $obj from the phan configuration

* Fix issues with undeclared $obj

* Fix issues with undeclared $obj

* Fix issues with undeclared $obj
 2024-08-27 04:57:04 +02:00
Laurent Destailleur
ba25c49333 Fix permiss 2024-08-22 14:10:59 +02:00
Laurent Destailleur
b8acc8cbb4 Fix missing test on permission 2024-08-22 13:38:51 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712) 
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
 2024-08-22 03:31:04 +02:00
Lucas Marcouiller
52c40c9031 New massaction reset for mailing target (#30710) 
* New massaction reset for mailing target

* Update mails.lang

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-21 15:28:23 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704) 
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
 2024-08-21 13:23:35 +02:00
HENRY Florian
d551f200f2 new: when initHook() and restrictedArea() exists always execute first initHook() (#30703) 2024-08-20 23:32:43 +02:00
Frédéric Bagnol
0166b6c0e9 # FIX truncate mail server error message to fit to database (mailling module) (#30534) 
* truncate mail server error message  to fit to database

* fix typo

* substr under DB->escape

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-20 09:51:27 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661) 
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-19 02:05:27 +02:00
Jon Bendtsen
76b8327b40 NEW: API close proposal now supports both private and public note (#30659) 
* NEW: API close proposal now supports both private and public note

* build errors

* build errors v2

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-18 16:16:47 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645) 
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
 2024-08-16 20:13:02 +02:00
Laurent Destailleur
69ac99e11a Fix sql error 2024-08-15 18:07:47 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00