# Fix undefined global varialbe user/card.php
Fix a few issues, one of which noticed in V21 UI.
Also notified by phan:
```
htdocs\user\card.php:626 PhanUndeclaredGlobalVariable Global variable $mesgs is undeclared
htdocs\user\card.php:2967 PhanUndeclaredGlobalVariable Global variable $soc is undeclared
```
# Fix: Cope with undefined country key in search array
Fix:
```
htdocs\partnership\partnership_list.php:533 PhanUndeclaredProperty Reference to undeclared property \Partnership->login
htdocs\partnership\partnership_list.php:793 PhanTypeMismatchArgumentProbablyReal Argument 4 ($filter) is null of type null but \FormAdmin::select_language() takes array|string[] (no real type) defined at htdocs\core\class\html.formadmin.class.php:74 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
```
* New setting for holiday updates
* FIX: holidays accounting at the end of taken month: log consumption for every request + update translations
* FIX: holidays accounting at the end of taken month: update conf name
* FIX: holidays accounting at the end of taken month: refactor monthly cron update
* FIX: holidays accounting at the end of taken month: update conf translation
* FIX: holidays accounting at the end of taken month: initialize holiday array + delete duplicate code
* New setting for holiday updates
* FIX: holidays accounting at the end of taken month: log consumption for every request + update translations
* FIX: holidays accounting at the end of taken month: update conf name
* FIX: holidays accounting at the end of taken month: refactor monthly cron update
* FIX: holidays accounting at the end of taken month: update conf translation
* FIX: holidays accounting at the end of taken month: initialize holiday array + delete duplicate code
* FIX: holidays accounting at the end of taken month: clean code
* FIX: holidays accounting at the end of taken month: empty now used on variables
* FIX: holidays accounting at the end of taken month: resolve not casted var in sql request
* FIX: holidays accounting at the end of taken month: now using only dolibarr functions
* FIX: holidays accounting at the end of taken month: fix php-stan and rework casting to int
* FIX: holidays accounting at the end of taken month: fix php-stan and rework casting to int (2)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Yannis Hoareau <93135242+JustRaosha@users.noreply.github.com>
* Fix: complete fix for #31117
Use getSommePaiement(), getSumCreditNotesUsed() and getSumDepositsUsed() to get already paid amount of invoice
to display correct invoice status
* fix for PHPStan
---------
Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
* NEW Accountancy - Add general account on thirdparty - SQL Part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* Fix Phan
* Use isModEnabled
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* fix set tiers as customer on online propal signature
* use setAsCustomer instead of set_as_client
---------
Co-authored-by: Ulysse Valdenaire <uvaldenaire@easya.solutions>
# Qual: Fix ci (phpstan notice)
While fixing the ci notice, also fixed the array definitions
which fixes both phan notices and phpstan notices seen on cti.
Removed the exception for phan on this file
* NEW get member by thirdparty account
* Update api_members.class.php
* Update api_members.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
