Commit Graph

128690 Commits

Author SHA1 Message Date
thibdrev
86623da9ec Merge branch 'Dolibarr:develop' into patch-8 2024-01-21 16:24:35 +01:00
Laurent Destailleur
b128ec6a4b Merge pull request #27692 from thibdrev/patch-3
qual: phpstan
2024-01-21 16:06:44 +01:00
Laurent Destailleur
b4174e7a01 Merge pull request #27688 from libremaster/develop
CRON: fetchAll will return list of Cronjob object instead of Cronjobline
2024-01-21 16:05:38 +01:00
Laurent Destailleur
1c0fd5f4d0 Merge pull request #27702 from mdeweerd/qual/spelling
Qual: Fix spelling.
2024-01-21 16:00:33 +01:00
Laurent Destailleur
6ccea73912 Merge pull request #27704 from mdeweerd/flow/limit-cache-storage
Qual: Store phpstan cache only if not loaded or successful run
2024-01-21 16:00:04 +01:00
MDW
19ac1e4b02 Qual: Store phpstan cache only if not loaded or successful run
The PHPStan steps run a long time for the latest runs and I suspect that
this may be because of a bad cache, possibly includeing:
```
Result cache was not saved because of non-ignorable exception: Syntax error, unexpected } on line 378
``` .

This change should only save the cache if the run was successful or if no cache
was loaded.  The possibly preserves a cache that still reduces the run time.

For instance, the following got an empty cache, saved at 2024-01-19T21:28:22.18Z.
- https://github.com/Dolibarr/dolibarr/actions/runs/7589384926
That was an aborted run:
- https://github.com/Dolibarr/dolibarr/actions/runs/7589372703/job/20673878193

So I added `cancelled()` to avoid overwriting valid cache and phpstan cache
will only be written if the outcome was success or if the cache could not
be loaded before.

I also updated the version for the cache action.
2024-01-21 15:05:47 +01:00
MDW
ef95c56ecd Qual: Fix spelling.
# Qual: Fix some spelling
2024-01-21 13:37:53 +01:00
thibdrev
8e69be7f8d qual: phpstan
htdocs/product/card.php	578	Property CommonObject::$barcode_type (int) does not accept array|string.
htdocs/product/card.php	820	Property CommonObject::$barcode_type (int) does not accept array|string.
2024-01-20 21:55:24 +01:00
thibdrev
02da32736e qual: phpstan
htdocs/fourn/facture/card.php	763	Property CommonInvoice::$socid (int) does not accept array|string.
2024-01-20 21:27:24 +01:00
Christophe TREMBLAY-GUILLOUX
c1c45a171a Debug 2024-01-20 14:23:17 +01:00
Christophe TREMBLAY-GUILLOUX
2f32ac6fe3 Debug 2024-01-20 14:16:14 +01:00
Christophe TREMBLAY-GUILLOUX
0701d31325 Someone did a typo mistake 2024-01-20 14:03:56 +01:00
Christophe TREMBLAY-GUILLOUX
6e1a8f2942 Merge remote-tracking branch 'upstream/develop' into develop 2024-01-20 13:42:46 +01:00
Christophe TREMBLAY-GUILLOUX
2ac3b914cb CRON: fetchAll->lines will return list of Cronjob object instead of Cronjobline object 2024-01-20 13:42:39 +01:00
Laurent Destailleur
02d520b5a7 Merge pull request #27604 from W1W1-M/fix-dolresource-phpstan-lvl3
Fix phpstan dolresource
2024-01-20 00:46:32 +01:00
Laurent Destailleur
72f2547422 Update dolresource.class.php 2024-01-20 00:46:02 +01:00
Laurent Destailleur
c78cd05818 Merge pull request #27638 from mdeweerd/qual/admin_lib
Qual: Cleanup method to ignore misspelled key
2024-01-20 00:42:41 +01:00
Laurent Destailleur
c6b99dbea8 Merge pull request #27635 from frederic34/patch-3
fix phpstan
2024-01-20 00:41:22 +01:00
Laurent Destailleur
1f13ec7e39 Merge pull request #27634 from frederic34/patch-8
fix phpstan
2024-01-20 00:41:07 +01:00
Laurent Destailleur
190d335f24 Merge pull request #27637 from mdeweerd/fix/dol_print_error
Fix: Add missing  argument to dol_print_error
2024-01-20 00:38:27 +01:00
Laurent Destailleur
5d5d996b4a Merge pull request #27636 from frederic34/patch-5
clean code
2024-01-20 00:38:12 +01:00
Laurent Destailleur
f68dc61a73 Merge pull request #27686 from thibdrev/patch-12
qual: phpstan
2024-01-20 00:37:32 +01:00
Laurent Destailleur
76ae986a77 Merge pull request #27685 from thibdrev/patch-11
qual: phpstan
2024-01-20 00:37:07 +01:00
Laurent Destailleur
b8c5b9d3a0 Merge pull request #27684 from thibdrev/patch-10
qual: phpstan
2024-01-20 00:36:52 +01:00
Laurent Destailleur
b996bb1426 Merge pull request #27683 from thibdrev/patch-9
qual: phpstan
2024-01-20 00:36:36 +01:00
Laurent Destailleur
758404ce1c Merge pull request #27682 from thibdrev/patch-8
qual: phpstan
2024-01-20 00:36:23 +01:00
Laurent Destailleur
de0ae0032f Merge pull request #27678 from thibdrev/patch-3
qual: phpstan
2024-01-20 00:35:48 +01:00
Laurent Destailleur
f0373041af Merge pull request #27681 from thibdrev/patch-7
qual: phpstan
2024-01-20 00:34:24 +01:00
Laurent Destailleur
0de4793bf8 Merge pull request #27640 from frederic34/date_lim_reglement
phpdoc
2024-01-19 22:29:28 +01:00
Laurent Destailleur
fc30521611 Merge pull request #27641 from mdeweerd/fix/missing_arg
Fix: Missing 'ref_supplier' argument
2024-01-19 22:28:15 +01:00
Laurent Destailleur
8c8fea88d2 Merge pull request #27642 from mdeweerd/fix/stripe_exceptions
Fix: Update Stripe Exception class references
2024-01-19 22:26:35 +01:00
thibdrev
1f7c183301 Update paymentloan.class.php - $numpayment is string (not int) 2024-01-19 21:16:08 +01:00
Laurent Destailleur
d3528306d8 Merge pull request #27644 from thibdrev/patch-1
qual: phpstan
2024-01-19 21:12:50 +01:00
Laurent Destailleur
a74014c101 Merge pull request #27645 from libremaster/develop
CLEANING: lines of code not usefull
2024-01-19 21:10:56 +01:00
thibdrev
f8c21d6ce3 Merge branch 'Dolibarr:develop' into patch-3 2024-01-19 21:07:50 +01:00
Laurent Destailleur
5d9b422ddd Merge pull request #27680 from thibdrev/patch-6
qual: phpstan
2024-01-19 21:07:37 +01:00
thibdrev
4187f8c52a Merge branch 'Dolibarr:develop' into patch-3 2024-01-19 21:07:35 +01:00
thibdrev
aafe309b58 Update payment.php - num_payment can be string => GETPOST with alphanohtml 2024-01-19 21:05:51 +01:00
Laurent Destailleur
6ef40b037e Merge pull request #27679 from thibdrev/patch-5
qual: phsptan
2024-01-19 20:49:45 +01:00
Laurent Destailleur
24e20737e4 Merge pull request #27646 from FHenry/dev_upgrade_answercolumn_knowledgmanagement
feat: knowledgemanagement change answer column to longtext
2024-01-19 20:46:35 +01:00
thibdrev
704caa4261 qual: phpstan
htdocs/salaries/class/salary.class.php	317	Property Salary::$fk_user (int) does not accept string.
htdocs/salaries/class/salary.class.php	325	Property Salary::$fk_bank (int) does not accept string.
htdocs/salaries/class/salary.class.php	326	Property Salary::$fk_user_author (int) does not accept string.
htdocs/salaries/class/salary.class.php	327	Property Salary::$fk_user_modif (int) does not accept string.
2024-01-19 20:31:29 +01:00
thibdrev
f5d6c65c79 qual: phpstan
htdocs/salaries/paiement_salary.php	113	Property PaymentSalary::$fk_typepayment (int) does not accept array|string.
2024-01-19 20:25:54 +01:00
thibdrev
070478c750 qual: phpstan
htdocs/reception/card.php	617	Property CommandeFournisseurDispatch::$id (int) does not accept array|string.
htdocs/reception/card.php	659	Property CommandeFournisseurDispatch::$id (int) does not accept array|string.
htdocs/reception/card.php	660	Property CommandeFournisseurDispatch::$fk_entrepot (int) does not accept array|string.
htdocs/reception/card.php	685	Property CommandeFournisseurDispatch::$id (int) does not accept array|string.
2024-01-19 20:21:20 +01:00
thibdrev
0a119e8491 qual: phpstan
htdocs/public/project/suggestconference.php	259	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/project/suggestconference.php	260	Property CommonObject::$state_id (int) does not accept array|string.
2024-01-19 20:15:38 +01:00
thibdrev
1ca92fe72e qual: phpstan
htdocs/public/project/suggestbooth.php	258	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/project/suggestbooth.php	259	Property CommonObject::$state_id (int) does not accept array|string.
2024-01-19 20:14:10 +01:00
thibdrev
6a36b8f0b8 qual: phpstan
htdocs/public/project/new.php	231	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/project/new.php	232	Property CommonObject::$state_id (int) does not accept array|string.
2024-01-19 20:12:17 +01:00
thibdrev
26b845e052 qual: phpstan
htdocs/public/partnership/new.php	275	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/partnership/new.php	276	Property CommonObject::$state_id (int) does not accept array|string.
htdocs/public/partnership/new.php	303	Property Societe::$country_id (int) does not accept array|string.
htdocs/public/partnership/new.php	312	Property CommonObject::$state_id (int) does not accept array|string.
2024-01-19 20:09:21 +01:00
Laurent Destailleur
32b05403ce Merge pull request #27674 from frederic34/patch-7
fix phpdoc and default value
2024-01-19 20:08:58 +01:00
Laurent Destailleur
19c72ffacd Merge pull request #27675 from mc2contributor/fixundef
Fix PHP undefined variable warning
2024-01-19 20:06:59 +01:00
thibdrev
f5d064175f qual: phsptan
htdocs/projet/stats/index.php	86	Property Stats::$year (int) does not accept array|string.
htdocs/projet/stats/index.php	204	Property Stats::$year (int) does not accept array|string.
2024-01-19 20:06:03 +01:00