Commit Graph

14550 Commits

Author SHA1 Message Date
Laurent Destailleur
96cdb50886 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 03:54:14 +02:00
Laurent Destailleur
9f693ea049 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 03:53:42 +02:00
Laurent Destailleur
3e9a0cfa99 Debug v20 2024-09-09 03:52:25 +02:00
MDW
32732d37d2 Qual: Improve typing in Export class (#30859)
* Update baseline

* Qual: Improve typing in Export class

* Add 'abstract' methods to help with typing

* Add some typing

* Improve typing in export modules

* Improve typing for AccountancyExport

* Qual: PHPDoc executeCLI (nullable arguments, range)

* PHPDoc for export function

* Fix $permissiontoClose -> $permissiontoclose

* PHPDoc - Improve AccountingJournal typing

* Improve export_journal tpl typing

* Improve html.formsetup typing

* Impove commonfieldsexport typing

* Improve extrafieldsinexport typing

* Fix typing, initialisation

* Fix typing intracommreport

* Ensure string in $error for CronJob
2024-09-09 03:15:26 +02:00
Laurent Destailleur
e003c6a516 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 02:20:15 +02:00
Laurent Destailleur
b1b1491299 Debug the numbering module of tasks. Secodn param must be Project. 2024-09-06 15:38:52 +02:00
Frédéric FRANCE
80999f9a61 fix phpstan (#30871)
* fix phpstan

* fix phpstan
2024-09-06 13:47:24 +02:00
Frédéric FRANCE
eb04c5c427 fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Laurent Destailleur
c972f44dc2 Debug v20 - Fix mandatory fields 2024-09-06 02:59:21 +02:00
Laurent Destailleur
40f0173678 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-05 22:44:57 +02:00
Laurent Destailleur
07546f4d7e Debug v20 2024-09-05 18:10:24 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
c98273fed1 Fix phan error; Currently getExample has different signature defined
into parents
2024-09-03 17:59:06 +02:00
Laurent Destailleur
f23ff1867a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-03 17:52:25 +02:00
Laurent Destailleur
d2608dfb08 Fix type 2024-09-03 17:50:36 +02:00
Laurent Destailleur
14d5b4bcc3 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-02 12:14:51 +02:00
Laurent Destailleur
aa096719b2 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-02 11:18:06 +02:00
atm-lucas
c3e6df4d91 FIX - Substitution error in ticket emails in the subject (#30778)
* fix missing substitutions

* test on ->substit
2024-09-01 14:55:59 +02:00
Laurent Destailleur
8d786cb73a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-01 14:35:58 +02:00
Laurent Destailleur
3f9b2d9d57 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-01 14:15:57 +02:00
John BOTELLA
079f6487fd Fix : php 8 warnings v19.0 (#30799)
* fix php8 err

* Fix php 8

* fix missing precommit hooks

* Update htdocs/commande/list.php

* Update htdocs/commande/list.php
2024-08-31 19:42:15 +02:00
Laurent Destailleur
4904eea6ce Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-31 18:19:06 +02:00
Laurent Destailleur
79b1a293e9 Fix barcode for virtual card must not pass content on get url. 2024-08-31 18:18:45 +02:00
MDW
a8367a6cd8 Qual: Fix getNextValue related phan notices (part2) (#30752)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
Lucas Marcouiller
2662725819 Fix select with text area and generalisation for update (#30794)
* Fix select with text area and generalisation for update

* fix CI

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-08-29 13:32:06 +02:00
Frédéric FRANCE
5947bea924 🛟 fix phpstan (#30793) 2024-08-29 13:28:49 +02:00
Lucas Marcouiller
94b3566ddc fix textarea with select by adding a button (#30785)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-08-29 09:27:42 +02:00
William Mead
8bbe0516f4 Fix ticket category html form warnings (#30773)
* Fixed undefined properties

* Added contributor details
2024-08-29 09:26:00 +02:00
MDW
00e2ed5529 Qual: 🛟 Fix CI Issues ($db to $this->db / LDAP typing / Win-ci cache md5sum) (#30774)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Qual: Fix LDAP typing

* Fix suspected issue with environment max size and md5sum working on limited files

* Correct typing hint for email_date
2024-08-29 09:24:33 +02:00
MDW
e6630cd7d1 Qual: Improve dol_syslog (#30782)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Improve dol_syslog

# Qual: Improve dol_syslog

The changes:
- Keep the log file open for less time (better for concurrency);
- Open the log file only to append data (no internal preparation for writing);
- Avoids re-assigning a constant array;
- Add PHPDoc information about the array parameters and return values;
- May reduce the computation of global settings;
- Result in a slight performance improvement.
2024-08-29 08:49:27 +02:00
Laurent Destailleur
b3c28155b7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-28 19:13:48 +02:00
Laurent Destailleur
8232a5cdad Clean code 2024-08-28 18:50:33 +02:00
Laurent Destailleur
c0be147c02 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 20:01:25 +02:00
Laurent Destailleur
e783a2da16 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-08-27 19:41:25 +02:00
Laurent Destailleur
f07ebe0065 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 07:08:56 +02:00
William Mead
30805c68da NEW intervention signed status update (#30629)
* Added confirm_sign, confirm_unsign, sign & unsign actions. Added sign-unsign button.

* Updated create & fetch methods with signed_status

* Added EN localization

* Added intervention signed notification

* Added intervention signed auto event. Updated EN localization. Fixed trigger.

* Cleaned code

* Added signed label to status badge

* Cleaned code

* Added signed statues dictionary. Added method to get signed status label badge.

* Added signed status to intervention list

* Added sign localizations

* Added sign confirm select. Refactored signed statuses dictionary.

* Added method to get localized signed statuses arrray. Refactored code. Added EN localization.

* Fixed signed status update

* Cleaned code

* Updated EN localization

* Cleaned code

* Changed sign workflow to exclude only drafts

* Added signed status change with online sign

* Improved signed status workflow

* Removed db structure changes

* Updated action trigger to FICHINTER_MODIFY

* Updated EN localizations

* Refactored to use FICHINTER_MODIFY trigger with localized context message. Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Updated EN localizations.

* Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Cleaned Ecode.

* Fixed undeclared constant

* Added contributor details

* Updated notification logic to use object context to pass signature status

* Refactored to make use of object context for event notification. Cleaned code.

* Fixed deprecated method

* Cleaned code
2024-08-27 07:01:03 +02:00
William Mead
ded9d09c00 LDAP fixes for php8.1+ (#30725)
* Log LDAP error information only on debug. Added unbind condition. Added contributor details.

* Refactored unbind for PHP 8.1+. Refactored connect_bind for PHP 8.3+. Cleaned code.

* Cleaned code

* Refactored error management
2024-08-27 06:34:08 +02:00
Laurent Destailleur
dcfaae3bd5 Clean code: fight against global vars 2024-08-27 06:20:04 +02:00
Francis Appels
a8ddeff35c Fix some php warning (#30753)
* Fix php warning on send email

* Fix php warning on getTotalWeightVolume when no lines.

* Fix totalOrdered totalToShip should be int
2024-08-27 04:52:47 +02:00
MDW
f5c7ca1769 Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence (#30754)
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php

* Qual: PHPDoc for import/export array types

* Qual: Add PHPDoc types to import.class.php

* Fix PhanPluginUnknownObjectMethodCall in stats.class.php

* Add methods expected on ModeleImport child classes

* Force imapemail type for phan

* Qual: Update phan baseline

* Qual: Fix Undefined/Undeclared phan notices in module_help

* Update baseline
2024-08-27 04:51:41 +02:00
lamrani abdelwadoud
ca26bc5b8a New dislay for listing events of invoic supplier (#30714)
* New dislay for listing events of invoic supplier

* Fix phpstan errors

* Fix active tab and refSupplier in agenda file

* Fix whitespace and brackets
2024-08-24 13:41:20 +02:00
Laurent Destailleur
a59e933d59 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-22 14:47:00 +02:00
Laurent Destailleur
e631ce7475 Fix sanitizing dol_openinpopup 2024-08-22 14:46:10 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712)
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
2024-08-22 03:31:04 +02:00
Laurent Destailleur
5797a0db3f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-22 02:54:55 +02:00
Laurent Destailleur
fee2185170 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-08-22 02:52:27 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
HENRY Florian
cb636e217a fix: catch error extrafields delete (#30522)
* fix: return error when extrafield DDLDropField failed

* fix: return error when delete extrafield failed

* fix: VAT is already calculted if not post (#30683)
2024-08-21 13:06:22 +02:00
HENRY Florian
0dc5f67d64 NEW: add warehouseId parameters in select_produit to limit result to existing product in select (#30477)
* ongoing

* new: add warehouseId parameters inselect_produit to limit result to existing product in select

* new: add warehouseId parameters inselect_produit to limit result to existing product in select

* new: add warehouseId parameters inselect_produit to limit result to existing product in select

* try reveiw

* fix from review

* fix from reiview

* review php stan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-20 23:29:35 +02:00
Nicolas Domenech
ce199c4206 Fix : SQL order on extrafields type chkbxlst (multiselectarray) (#30689) 2024-08-20 12:41:23 +02:00