Commit Graph

14550 Commits

Author SHA1 Message Date
Laurent Destailleur
ed8560ca07 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-19 22:51:52 +02:00
Laurent Destailleur
0ba26aacdd FIX Debug option WORKFLOW_TICKET_LINK_CONTRACT. Bad id stored. Bad
condition to activate it. Bad position in setup. Bad selection of
catrogy on setup.
2024-09-19 22:51:33 +02:00
Laurent Destailleur
cf931a8a90 FIX retreiving user specific constant 2024-09-19 14:27:08 +02:00
Laurent Destailleur
f00a07e564 FIX Translation of widget label into combo 2024-09-19 13:29:07 +02:00
MathildeMar
2fd6be2112 Bug fix: substitution variables in notification of a quote signed by customer
Add fetch_thirdparty before getCommonSubstitutionArray to initialize substitution variables of type __THIRDPARTY_XXX__ in notification mails
2024-09-19 10:56:42 +02:00
Laurent Destailleur
26b7c59fc6 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-18 13:29:01 +02:00
Laurent Destailleur
c03cba8748 Clean code 2024-09-18 12:08:51 +02:00
MDW
099dbd9c1e Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Benjamin Falière
dcba3347d8 Retroport: FIX determine multi-currency price on object line create tpl (#28021) (#30535)
* NEW determine multi-currency price on object line create tpl (#28021)

* Update html.form.class.php

---------

Co-authored-by: lvessiller-opendsi <lvessiller@open-dsi.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-18 03:22:38 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-18 02:45:54 +02:00
Frédéric FRANCE
3ecae791e1 fix indexFile on update (#30998) 2024-09-18 00:59:47 +02:00
lamrani abdelwadoud
5fcca27fc4 NEW display when click on NEWS templateDrop down for model (#30332)
* New update for templateMail by creating files

* New updating for get php content

* Update html.formmail.class.php

* Fix updating content news

* Fix CTI Errors

* edit html file for news

* NEW display for news with option

* replace file in ajax folder

* fix multiselect news

* Fix phan errors and remove part of useless css

* Fix brakets needed in script

* Fix Phan errors

* Fix display multiselect and fix security injection

* cancel removing part of code for classe modelMail

* Fix phstan errors

* Fix space line

* Fix error phpStan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-17 15:37:34 +02:00
Laurent Destailleur
925665196c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-17 10:30:21 +02:00
Laurent Destailleur
8007e6ff86 NEW Can set date of transmission in 1 click when validating SEPA
transfer file
2024-09-17 10:29:57 +02:00
Frans Bosman
93aa372c22 Update html.form.class.php (#30952)
* Update html.form.class.php

When using the hook selectProduitsFournisseurListOption and there is no supplier-price found the fk_soc will be empty so in the hook-code you don't know which supplier the order is for

* Update html.form.class.php

* Update html.form.class.php

* Update html.form.class.php

* Update html.form.class.php

* Update html.form.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-17 03:08:02 +02:00
Laurent Destailleur
69f7fe31a3 Fix text 2024-09-17 03:06:26 +02:00
Laurent Destailleur
15f95c4628 Fix text 2024-09-17 03:05:26 +02:00
Frédéric FRANCE
5fd996821b fix phpstan (#30962)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* Update html.formadmin.class.php
2024-09-17 02:54:44 +02:00
Laurent Destailleur
e09fa82deb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-17 02:51:19 +02:00
Laurent Destailleur
cb3ce12bfc Debug webportal module Fix #30981 2024-09-17 02:29:43 +02:00
Laurent Destailleur
c617ab7c0e Debug webportal module Fix #30981 2024-09-17 02:25:45 +02:00
Laurent Destailleur
e9559d7d31 Fix phpstan 2024-09-17 00:39:32 +02:00
Frédéric FRANCE
763405a34c fix phpstan (#30985)
* fix phpstan

* fix phpstan
2024-09-17 00:23:25 +02:00
Frédéric FRANCE
e43789a3d7 fix phpstan (#30984)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-17 00:22:47 +02:00
Laurent Destailleur
cd8ddb7a8b FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:59:13 +02:00
Laurent Destailleur
65edbd5f9f FIX better compatibility with some old extrafield syntax filter 2024-09-16 15:50:47 +02:00
MDW
9a9e851494 Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
Laurent Destailleur
22ae541e3b Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 00:08:33 +02:00
Laurent Destailleur
283bd723ec Debug v20 - Fix filter on extrafields for select from table 2024-09-15 23:51:03 +02:00
Laurent Destailleur
c462a572ee Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-14 02:44:26 +02:00
William Mead
72aec91064 NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
1f33c81038 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 22:06:18 +02:00
Laurent Destailleur
6a15df3a52 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-12 22:01:08 +02:00
Laurent Destailleur
5b4c404957 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-12 21:59:59 +02:00
Laurent Destailleur
1b24270a46 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-09-12 21:59:42 +02:00
Laurent Destailleur
65e5899442 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-09-12 21:58:28 +02:00
Marc de Lima Lucio
d17890f05b FIX: purge files cron: php warnings when rest module enabled (#30919) 2024-09-12 21:57:41 +02:00
Lucas Marcouiller
ef2ec011f5 Fix #30828 bad save of contract id in ticket card (#30916)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-09-12 21:34:28 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
Laurent Destailleur
1a651ad80b Implement a TODO for possible perf enhancement. 2024-09-11 14:55:57 +02:00
CODE42 FR
d76f689bc2 [#29371] Fixed : Php wanring on separate type extra field update (#30910)
Co-authored-by: TREBUCHET <ravi@code42.fr>
2024-09-10 16:39:11 +02:00
CODE42 FR
c4a19f4022 [#29371] Fixed : Php wanring on separate type extra field update (#30910)
Co-authored-by: TREBUCHET <ravi@code42.fr>
2024-09-10 16:38:33 +02:00
William Mead
d0c96c99e0 Qual common signed object trait (#30913)
* Moved signed status properties & methods to reusable class trait

* Cleaned code

* Updated EN localization

* Fixed Phan warnings

* Fixed Phan warnings

* Added type check. Updated PHPDoc.

* Refactored class properties

* Cleaned PHPDoc

* Revert "Refactored class properties"

This reverts commit 1beb40a7

* Reapply "Refactored class properties"

This reverts commit 9e3d9d554c.

* Fixed PHPDoc

* Fixed class file name
2024-09-10 16:22:25 +02:00
Laurent Destailleur
e847c072a2 Debug v20 2024-09-10 11:25:28 +02:00
Laurent Destailleur
9eb61af370 Debug v20 2024-09-10 11:24:55 +02:00
William Mead
fb6677010d NEW contract signed status update (#30779)
* Moved signed status constants to array dictionary

* Added getLibSignedStatus & getSignedStatusLocalisedArray methods

* Updated fetch & create methods for signed_status

* Added signed status to status badge

* Updated signed_status module builder field

* Added object context signed status for action trigger

* Added signed status to contract list

* Fixed signed status for contract list

* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.

* Fixed old contract without signed status

* Added contract modify notification

* Added contract signed status update

* Updated EN localizations

* Fixed contract notification administration

* Fixed notification message

* Fixed contract status badge

* Fixed langs

* Fixed langs key

* Fixed duplicate localization
2024-09-10 03:04:49 +02:00
Laurent Destailleur
fc1b4c9697 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-10 02:14:08 +02:00
MDW
506454b10a Qual: Resolve ~200 phan notices/~100 phpstan notices (#30879)
* bookkeeping\card.php, productaccount

* Fix bookkeeping/listbyaccount

* Typing for accountancycategory

* Fix typing accountancyimport

* Typing accountingaccount

* Typing api_accountancy

* bookkeeping typing

* Fix typing lettering

* Typing for accountancy/customer/list

* Typing accountancy/journal/bankjournal

* typing accountancy/journal/variousjournal

* Typing accountancy/supplier/list

* Initialisations in accountancy/journal/expensereportsjournal

* Initialisations in accountancy/journal/purchasesjournal

* Initialisations in accountancy/journal/sellsjournal

* Update baseline
2024-09-10 02:11:53 +02:00
kkhelifa-opendsi
d29ebee2ac FIX avoid from re-initializing array result on nested hook getEntity (#30626) 2024-09-09 04:35:13 +02:00