* FIX: online signature (#28608) Update signature.lib.php
If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in signature.lib.php line 77, will remove any existing space in the Commercial proposal numbering. The result is that the online signature form will miss data in field “Third-party” and “Amount”.
* FIX: online signature (#28608) Update payments.lib.php
If Commercial proposal numbering contains a mask that’s includes a space, that will affect the result of the online signature form. When generating the online signature form, the code in core/lib/payments.lib.ph, will remove any existing space in the Commercial proposal numbering.
# Qual: Precise typing for Societeaccount's fields property
Better typing helps static analysis and fixes the message:
PhanTypeMismatchArgumentInternal Argument 2 ($array) is $object->fields['site']['arrayofkeyval'] of type null but \array_key_exists() takes array
* Fix phpstan workflow file
# Fix phpstan workflow file
Line was split in two, joined
* qual: set memory limit to 'unlimited' (-1)
* Remove some stubs to check impact
* Fix: Verify execution time limit
* Remove stub files to reuse cache
* Qual: Rename distribution phpstan.neon to phpstan.neon.dist
# Qual: Rename distribution phpstan.neon to phpstan.neon.dist
This allows the developer to override some settings locally
Also update the .gitignore file with phpstan.neon and some other other
ignores (cache, local log files, temporary edit files).
* Enable debug on phpstan
* Re-enable stubs
* Fix: Change parallel settings to defaults, remove buffer
'buffer' is not a documented parameter, removing it.
Removing some configuration settings as the defaults are higher and
should adapt better to the target machine
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions
Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
* Qual: Force typing on variable fixing several phan notices
# Qual: Force typing on variable fixing several phan notices
Forcing DolibarrModules on $objMod after assignment to fix typing checks
* Qual: Fix typing on import_label/export_label
* Fix: join->implode
# Fix: join->implode
Update new cases of join
* Fix: Duplicate if condition in if/else sequence
# Fix: Duplicate if condition in if/else sequence
Fixed repeated if condition and action
* Qual: phan: Add more global definitions
# Qual: phan: Add more global definitions
Add some more typing information for globals
* Qual: phan: ignore local conf file which may contain exceptions
* Qual: phan: add a few more global typings
