Commit Graph

130797 Commits

Author SHA1 Message Date
Frédéric FRANCE
a2c92f183c Phpstan fix (#28637)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-05 17:12:36 +01:00
Frédéric FRANCE
bc2f527e41 add phpdoc (#28639)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc
2024-03-05 17:11:46 +01:00
thibdrev
2664661afc qual: phan for htdocs/core/lib/functions.lib.php (#28640)
68 entries for "Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299"

Examples (first 10):

htdocs/accountancy/admin/categories.php	155	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/admin/categories.php	189	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/bookkeeping/card.php	778	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/eventorganization.php	341	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	596	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	603	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	627	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	293	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	300	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/multicurrency.php	115	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
2024-03-05 16:32:40 +01:00
MDW
dc72cd390b Qual: Clean up caches when PR is closed (#28648)
# Qual: Clean up caches when PR is closed

This will clean up caches when a PR is closed.

This requires that `actions:write` is enabled.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 16:31:45 +01:00
Laurent Destailleur
37e3e3bd89 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-05 16:29:32 +01:00
Laurent Destailleur
beba98be64 Fix phan 2024-03-05 16:28:59 +01:00
Sébastien NASSIET
cb77ff0a16 Set import_key in import when update record (#28644)
* fix can't delete pdf if ref is not encoded (#28630)

* fix typo in ChangeLog (#28613)

* fix typo in ChangeLog

* Update ChangeLog

* FIX: Count of virtual stock at Services and MoLine with disabled stock change (#28580)

* fix the count of virtual stock

* - fix "Found non sanitized string" ?

---------

Co-authored-by: christian.humpel <christian.humpel@gmail.com>

* Set import_key in import when update record

* Set import_key in import when update record

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Christian Humpel <78662388+Humml87@users.noreply.github.com>
Co-authored-by: christian.humpel <christian.humpel@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 16:11:32 +01:00
PsyCrow
13f3dcf39c FIX #28641 (#28642)
* FIX #28641

FIX #28641 Annoying autocomplete on datepicker

* Update html.form.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 15:56:38 +01:00
Laurent Destailleur
f1501878c0 CSS 2024-03-05 15:53:23 +01:00
Laurent Destailleur
5c80d4b4fd CSS 2024-03-05 15:43:11 +01:00
Regis Houssin
93ccee2efb FIX wrong GETPOST check (#28643)
* FIX wrong GETPOST check

* FIX why GETPOST("search_type", "int") is not the same result of
GETPOSTINT("search_type") ?
2024-03-05 11:06:52 +01:00
Laurent Destailleur
bf6c662d25 Fix phpunit 2024-03-05 04:06:21 +01:00
Laurent Destailleur
cda8a7d241 css 2024-03-05 03:57:56 +01:00
Laurent Destailleur
c544efec7f QUAL: Remove use of customurl filter. Must use the USF syntax. 2024-03-05 03:51:36 +01:00
Laurent Destailleur
847c7a73c8 Doc 2024-03-05 01:30:36 +01:00
Laurent Destailleur
f0693549b3 Fix bad message 2024-03-05 01:12:28 +01:00
Laurent Destailleur
41c8c23dbb Disable not complete test 2024-03-05 01:07:19 +01:00
Laurent Destailleur
31ae1bf97f Fix restore stop on failure. No need to continue, we must fix first.
Make travis error analysis easier too.
2024-03-05 01:05:50 +01:00
Laurent Destailleur
aedffc6cee Fix cast 2024-03-05 00:52:01 +01:00
Laurent Destailleur
8abb608c17 Fix fetchAll for website pages 2024-03-05 00:42:44 +01:00
Laurent Destailleur
c3db669a10 Fix fetchAll for website pages 2024-03-05 00:38:20 +01:00
Laurent Destailleur
94a82716b7 Fix regression with GETPOSTINT 2024-03-05 00:26:24 +01:00
Laurent Destailleur
d09c9c0174 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-05 00:23:38 +01:00
Laurent Destailleur
ce010a54c7 Clean code and prepare a more powerfull phpunit check for sql forging. 2024-03-05 00:22:12 +01:00
Frédéric FRANCE
31ba3a3723 fix phpstan (#28633) 2024-03-04 20:14:52 +01:00
Frédéric FRANCE
52df5140a4 fix phpstan (#28632) 2024-03-04 20:14:30 +01:00
MDW
6f8b941c96 Fix: Script tests on Windows where PHP executable is not in path. (#28565)
# Fix: Script tests (on Windows)

- Set `exit(255)` instead of `exit(-1)` in `scripts/bank/export-bank-receipts.php`.
  On *nix, the -1 converts into an exist code of 255 but on windows it
  is -1, making the test fail.
- Add a helper method to execute php scripts using the php binary used
  to run phpunit.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-04 20:13:34 +01:00
Laurent Destailleur
04670b92b3 Fix var_dump 2024-03-04 20:13:08 +01:00
Laurent Destailleur
53e47df053 Use new return code rule 2024-03-04 20:05:18 +01:00
Laurent Destailleur
b15d71274a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-04 19:50:51 +01:00
Laurent Destailleur
fe5401d7e2 Doc 2024-03-04 19:50:36 +01:00
Laurent Destailleur
3bafcf5d00 Fix CLI tools must return a positive value on error for better cross
platform compatibility
2024-03-04 19:41:21 +01:00
JeromeBARBOTIN
c623558583 Verification of variables (#28629) 2024-03-04 18:52:41 +01:00
Laurent Destailleur
c181bbe2f2 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-04 18:34:05 +01:00
Laurent Destailleur
8528b3f363 Clean conf 2024-03-04 18:33:32 +01:00
MDW
b30dd4e707 Fix: Cache issue in windows-ci - add enableCrossOsArchive (#28607)
# Fix: Cache issue in windows-ci - add enableCrossOsArchive

There is an issue in actions/cache on windows and adding 'enableCrossOsArchive: true'
should fix it according to
https://github.com/actions/cache/issues/1275#issuecomment-1925217178
2024-03-04 18:28:24 +01:00
Frédéric FRANCE
44ce77dd37 fix phpstan (#28606) 2024-03-04 18:27:49 +01:00
Frédéric FRANCE
7090af2b51 fix phpstan (#28609)
* fix phpstan

* Update emailsenderprofile.class.php
2024-03-04 18:27:20 +01:00
MDW
6878a834a5 Fix: Remove extra space in translation key (#28611)
# Fix: Remove extra space in translation key

Fix the extra space in the key 'ImpossibleToContactAuthority' when calling trans.
2024-03-04 18:26:57 +01:00
Laurent Destailleur
e66e77e4a0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-04 18:22:27 +01:00
Laurent Destailleur
1cf5f31355 Fix #28620 2024-03-04 18:15:21 +01:00
Frédéric FRANCE
47dfcf9bfc clean code (#28616) 2024-03-04 18:13:32 +01:00
thomas-Ngr
cf7f40b739 new fetch() for classes Fournisseur and Client (#28621)
* New : introduce Fournisseur::fetch() and Client::fetch(). Add new parameters  and  to Societe::fetch()

* societe::fetch: both is_client and is_fournisseur false by default

* Simplify code
2024-03-04 18:11:50 +01:00
William Mead
f103278bb4 Qual phpstan cron card (#28626)
* Fixed unitfrequency type. Fixed localization.

* Cleaned code & comments. Added contributor details.
2024-03-04 18:08:07 +01:00
Laurent Destailleur
723b1b06e7 Debug v20 2024-03-04 18:06:55 +01:00
Frédéric FRANCE
21688a00dd Update bookcalindex.php (#28615) 2024-03-04 18:00:31 +01:00
William Mead
29d87ec14a Fixed lastresult type (#28628) 2024-03-04 17:58:21 +01:00
Laurent Destailleur
61dd78b95e Fix regression. Removed bad fixer. GETPOST(... int) is not GETPOSTINT 2024-03-04 17:49:43 +01:00
Laurent Destailleur
a2f5d6ad0b Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-04 14:47:25 +01:00
Laurent Destailleur
9f1393f6ea Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-04 14:46:54 +01:00