Commit Graph

130847 Commits

Author SHA1 Message Date
thibdrev
d79b3ba8ec qual: phpstan for htdocs/expedition/class/expedition.class.php (#28686)
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (CommonObject|string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (CommonObject|string) does not accept null.
2024-03-07 18:57:38 +01:00
MDW
c6333c7782 Fix: Missing parameter (#28691)
# Fix: Missing parameter

dol_print_error was missing db parameter
2024-03-07 18:57:18 +01:00
Laurent Destailleur
a72e1f08c1 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

Conflicts:
	htdocs/fourn/class/fournisseur.commande.class.php
2024-03-07 18:54:59 +01:00
Laurent Destailleur
f396bf1218 Fix compatibility 2024-03-07 18:53:21 +01:00
Laurent Destailleur
5f7192f475 Fix signature of delete method 2024-03-07 18:51:20 +01:00
Frédéric FRANCE
9b59445e39 fix unknown $user (#28687)
* fix unknown $user

* fix @param

* fix @param

* fix @param

* fix @param
2024-03-07 18:48:50 +01:00
Laurent Destailleur
61e69b352b Doc 2024-03-07 18:44:55 +01:00
thibdrev
c66f7d6345 qual: phpstan for htdocs/comm/action/class/ical.class.php (#28685)
htdocs/comm/action/class/ical.class.php	146	Property ICal::$file_text (string) does not accept null.
htdocs/comm/action/class/ical.class.php	171	Property ICal::$file_text (string) does not accept array|false.
2024-03-07 18:20:18 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
William Mead
f1c7b5729f Fix resource list (#28661)
* Move sql SELECT request to list

* Refactored list. Added mass actions. Added contributor details.

* Added dolresource delete

* Cleaned code
2024-03-07 17:01:36 +01:00
Sylvain Legrand
27f88b3ad5 Fix error using MAIN_FILL_SERVICE_DATES_FROM_LAST_SERVICE_LINE (#28662)
With PHP 8.1 an error occurs when editing the first line of a document
2024-03-07 16:57:53 +01:00
Frédéric FRANCE
14ffa142aa fix precommit and clean code (#28651)
* fix precommit

* fix precommit

* fix missing include

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* clean code

* clean code
2024-03-07 16:57:29 +01:00
thibdrev
b9c843c086 qual: phan for functions.lib.php (#28653)
* qual: phan for functions.lib.php

54 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 3 ($exclude) is null of type null but \getCommonSubstitutionArray() takes array (no real type) defined at htdocs/core/lib/functions.lib.php:8285

* phpcs
2024-03-07 16:55:12 +01:00
thibdrev
5659ba8de3 qual: phan for accountingaccount.class.php (#28669)
htdocs/accountancy/admin/productaccount.php	196	TypeError PhanTypeMismatchArgumentProbablyReal Argument 2 ($account_number) is null of type null but \AccountingAccount::fetch() takes string (no real type) defined at htdocs/accountancy/class/accountingaccount.class.php:182 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:50:42 +01:00
HENRY Florian
4fcbdf15ab fix: better inner join than comma for hook printFieldListFrom after (#28681)
* better inner jion than comme for hook after

* better inner jion than comme for hook after

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:49:41 +01:00
Rikard Bosnjakovic
1aa0f8227f Update card.php (#28679)
Fix #25130

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:43:04 +01:00
thibdrev
af9704acdc qual: phpdoc for htdocs/core/lib/pdf.lib.php (#28671) 2024-03-07 16:41:39 +01:00
Laurent Destailleur
56a8c752cf Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-07 16:38:55 +01:00
Laurent Destailleur
5e9dfc8090 Fix phan 2024-03-07 16:38:02 +01:00
MDW
38e69184d1 Fix typing hints (#28676) 2024-03-07 16:04:39 +01:00
thibdrev
fcfc70e02a qual: phpstan for htdocs/loan/class/loan.class.php (#28673)
htdocs/loan/class/loan.class.php	113	PHPDoc type int of property Loan::$totalpaid is not covariant with PHPDoc type float of overridden property CommonObject::$totalpaid.
2024-03-07 16:02:57 +01:00
thibdrev
18cc09fae6 qual: phan for htdocs/core/lib/ajax.lib.php (#28672)
29 entries for:

Argument 3 ($entity) is null of type null but \ajax_constantonoff() takes int (no real type) defined at htdocs/core/lib/ajax.lib.php:645
2024-03-07 16:02:14 +01:00
Laurent Destailleur
f00d3ff6dd Fix route not complete 2024-03-07 14:57:41 +01:00
Laurent Destailleur
21ef877772 Remove not used email layout 2024-03-07 11:07:28 +01:00
Laurent Destailleur
8bc7027ced Fix help on status of menu condition 2024-03-06 17:17:24 +01:00
Laurent Destailleur
c0ee90aa7d Exclude require, include into dol_eval 2024-03-06 17:13:05 +01:00
Laurent Destailleur
7866ee472b QUAL Clean code around dol_eval use 2024-03-06 17:07:24 +01:00
Laurent Destailleur
f9a2c8ec5d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-06 15:08:21 +01:00
Laurent Destailleur
f1aa29507a Fix sec more complete list of forbidden function 2024-03-06 15:01:25 +01:00
Laurent Destailleur
1a9fa740a5 Fix quote 2024-03-06 13:32:15 +01:00
Laurent Destailleur
8a2578d742 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-06 01:58:54 +01:00
Laurent Destailleur
1552fac711 Fix strict-origin 2024-03-06 01:54:41 +01:00
Laurent Destailleur
43b1adb4c6 Fix bad var name in security setup page 2024-03-06 01:40:06 +01:00
Laurent Destailleur
5c4c39da2a Debug module AI 2024-03-06 00:46:04 +01:00
Laurent Destailleur
c27551cbb7 Add a more complete message 2024-03-05 23:29:41 +01:00
Laurent Destailleur
64093cc378 Fix warning 2024-03-05 23:00:51 +01:00
Laurent Destailleur
fd2352645d Fix warning 2024-03-05 22:59:55 +01:00
Laurent Destailleur
95b7fe7dd3 Fix phpcs 2024-03-05 21:19:42 +01:00
Laurent Destailleur
cb20a1d033 Fix css 2024-03-05 21:18:14 +01:00
Laurent Destailleur
bf43be5e3b Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-05 17:30:02 +01:00
Frédéric FRANCE
de139de23d clean some files (#28649)
* clean some files

* clean some files
2024-03-05 17:24:18 +01:00
Laurent Destailleur
fbc6a645f7 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-05 17:23:46 +01:00
Laurent Destailleur
dffa967680 Sanitize table name 2024-03-05 17:23:33 +01:00
thomas-Ngr
8d9e9f13cf fix #28374 : tosell is not used anymore on products, use status (#28647) 2024-03-05 17:18:36 +01:00
John BOTELLA
26c307c0a4 Fix extrafield ajax search default on edit (#28631) 2024-03-05 17:16:11 +01:00
thibdrev
0ba3567ad6 qual: phan for htdocs/accountancy/admin/card.php (#28638)
* qual: phan for htdocs/accountancy/admin/card.php

htdocs/accountancy/admin/card.php	89	Plugin PhanPluginDuplicateExpressionAssignment Both sides of the assignment = are the same: $account_number

htdocs/accountancy/admin/card.php	152	Plugin PhanPluginDuplicateExpressionAssignment Both sides of the assignment = are the same: $account_number

* typo
2024-03-05 17:13:41 +01:00
Frédéric FRANCE
a2c92f183c Phpstan fix (#28637)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-05 17:12:36 +01:00
Frédéric FRANCE
bc2f527e41 add phpdoc (#28639)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc
2024-03-05 17:11:46 +01:00
thibdrev
2664661afc qual: phan for htdocs/core/lib/functions.lib.php (#28640)
68 entries for "Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299"

Examples (first 10):

htdocs/accountancy/admin/categories.php	155	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/admin/categories.php	189	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/bookkeeping/card.php	778	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/eventorganization.php	341	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	596	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	603	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	627	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	293	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	300	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/multicurrency.php	115	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
2024-03-05 16:32:40 +01:00
MDW
dc72cd390b Qual: Clean up caches when PR is closed (#28648)
# Qual: Clean up caches when PR is closed

This will clean up caches when a PR is closed.

This requires that `actions:write` is enabled.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 16:31:45 +01:00