mirror of
https://github.com/Dolibarr/dolibarr.git
synced 2026-03-21 01:23:54 +01:00
26f33edefc
* FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts The parameter amount_main_currency (argument #13 of addline()) was previously filled even when the bank account was already using the company main currency. This caused the field amount_main_currency to be populated incorrectly for transactions that were not foreign currency operations. The logic has been updated so that amount_main_currency is only filled when the transaction involves a foreign currency account. For accounts already using the company main currency, the value is now left NULL as expected. This aligns the behavior with the intended usage of addline() and prevents incorrect data in bank transaction records. (cherry picked from commitcdc36551d9) * FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts transfer.php: PhanTypeMismatchArgument: Argument 4 ($amount) is price2num((-1 * (float)($amount[$n]))) of type string but \Account::addline() takes float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan Check warning on line R189 Check warning: transfer.php: PhanTypeMismatchArgument: Argument 13 ($amount_main_currency) is $amount_main_currency_from of type ?string but \Account::addline() takes ?float defined at htdocs/compta/bank/class/account.class.php:611 CI-PULL-REQUEST / phan / Run phan (cherry picked from commitb8f222c3d9) * declare dateo (cherry picked from commit1401f74969) * declare of variables before action script (cherry picked from commit2b07209935)