Commit Graph

34349 Commits

Author SHA1 Message Date
Frédéric FRANCE
a2c92f183c Phpstan fix (#28637)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-05 17:12:36 +01:00
thibdrev
2664661afc qual: phan for htdocs/core/lib/functions.lib.php (#28640)
68 entries for "Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299"

Examples (first 10):

htdocs/accountancy/admin/categories.php	155	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/admin/categories.php	189	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/bookkeeping/card.php	778	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/eventorganization.php	341	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	596	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	603	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	627	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	293	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	300	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/multicurrency.php	115	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
2024-03-05 16:32:40 +01:00
Sébastien NASSIET
cb77ff0a16 Set import_key in import when update record (#28644)
* fix can't delete pdf if ref is not encoded (#28630)

* fix typo in ChangeLog (#28613)

* fix typo in ChangeLog

* Update ChangeLog

* FIX: Count of virtual stock at Services and MoLine with disabled stock change (#28580)

* fix the count of virtual stock

* - fix "Found non sanitized string" ?

---------

Co-authored-by: christian.humpel <christian.humpel@gmail.com>

* Set import_key in import when update record

* Set import_key in import when update record

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Christian Humpel <78662388+Humml87@users.noreply.github.com>
Co-authored-by: christian.humpel <christian.humpel@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 16:11:32 +01:00
PsyCrow
13f3dcf39c FIX #28641 (#28642)
* FIX #28641

FIX #28641 Annoying autocomplete on datepicker

* Update html.form.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 15:56:38 +01:00
Laurent Destailleur
bf6c662d25 Fix phpunit 2024-03-05 04:06:21 +01:00
Laurent Destailleur
cda8a7d241 css 2024-03-05 03:57:56 +01:00
Laurent Destailleur
c544efec7f QUAL: Remove use of customurl filter. Must use the USF syntax. 2024-03-05 03:51:36 +01:00
Laurent Destailleur
d09c9c0174 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-05 00:23:38 +01:00
Laurent Destailleur
ce010a54c7 Clean code and prepare a more powerfull phpunit check for sql forging. 2024-03-05 00:22:12 +01:00
Frédéric FRANCE
31ba3a3723 fix phpstan (#28633) 2024-03-04 20:14:52 +01:00
Frédéric FRANCE
44ce77dd37 fix phpstan (#28606) 2024-03-04 18:27:49 +01:00
Frédéric FRANCE
7090af2b51 fix phpstan (#28609)
* fix phpstan

* Update emailsenderprofile.class.php
2024-03-04 18:27:20 +01:00
Laurent Destailleur
723b1b06e7 Debug v20 2024-03-04 18:06:55 +01:00
William Mead
29d87ec14a Fixed lastresult type (#28628) 2024-03-04 17:58:21 +01:00
Laurent Destailleur
61dd78b95e Fix regression. Removed bad fixer. GETPOST(... int) is not GETPOSTINT 2024-03-04 17:49:43 +01:00
Laurent Destailleur
583480edbe FIX permission on payment file of a tax 2024-03-04 14:02:49 +01:00
Laurent Destailleur
63ef1b6c1f Fix regression with GETPOSTINT, not same than GETPOST(..., 'int') 2024-03-04 10:41:46 +01:00
Laurent Destailleur
8930bf83a9 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-03 20:59:45 +01:00
Laurent Destailleur
301bec664a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-03 19:59:34 +01:00
Laurent Destailleur
1e00cf34d4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-03 19:50:22 +01:00
Laurent Destailleur
17ff0972ab Fix use of invoke into computed fields 2024-03-03 19:35:37 +01:00
Frédéric FRANCE
6f58a45220 fix phpstan (#28605)
* fix phpstan

* fix phpstan

* fix too few parameters

* fix typo

* ActionComm::$ref is not covariant with PHPDoc type string

* fix default values
2024-03-03 18:55:30 +01:00
Laurent Destailleur
af6a091ab2 Fix 19.0.1 2024-03-03 18:55:10 +01:00
Laurent Destailleur
7b897ae27d Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-03 18:41:49 +01:00
Frédéric FRANCE
f5c0cfcf6b fix phpstan (#28588) 2024-03-03 17:09:55 +01:00
Frédéric FRANCE
e1b3a639c4 fix phpstan default value is incompatible with type string (#28592) 2024-03-03 17:09:24 +01:00
Cédric A
9e1cfb7c52 FIX issue #23022 (#28590)
* FIX issue #23022

* no longer necessary

* no longer necessary

* no longer necessary

* no longer necessary

* no longer necessary

* no longer necessary

* no longer necessary
2024-03-03 17:07:58 +01:00
Frédéric FRANCE
3663b9b305 fix phpstan (#28589)
* fix phpstan

* Update functions.lib.php
2024-03-03 17:00:06 +01:00
Laurent Destailleur
e865a8b171 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-03 16:57:31 +01:00
Frédéric FRANCE
b518bb0c9a fix phpstan (#28604) 2024-03-03 16:51:16 +01:00
Laurent Destailleur
5714ff8b16 Fix regression in dol_dir_list() 2024-03-03 16:31:22 +01:00
Frédéric FRANCE
da3a24c3f3 fix phpstan (#28597)
* fix phpstan

* fix phpstan
2024-03-03 15:53:31 +01:00
Laurent Destailleur
21feee3bc8 FIX Better test on validity of compute field syntax with parenthesis 2024-03-03 13:11:54 +01:00
MDW
eb1f6be1e2 Qual: Add information from backtrace when mysql request fails. (#28583)
# Qual: Add information from backtrace when mysql request fails.

This helps locate the line that was responsible for the SQL request
2024-03-02 19:57:59 +01:00
Frédéric FRANCE
cc1199664c fix default value is incompatible with type string (#28584) 2024-03-02 19:19:18 +01:00
Laurent Destailleur
e12c235185 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-02 16:52:44 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Frédéric FRANCE
074041d925 fix default value is incompatible with int (#28579) 2024-03-02 16:37:53 +01:00
Laurent Destailleur
39458e7c31 Better error management 2024-03-02 14:30:51 +01:00
Laurent Destailleur
2044a133e9 Fix warning 2024-03-02 13:15:20 +01:00
Frédéric FRANCE
99d7b76ba9 fix phpstan (#28568) 2024-03-02 12:40:25 +01:00
Frédéric FRANCE
d0e6933b6d fix phpstan (#28567) 2024-03-02 12:39:30 +01:00
Thomas C
595d735fee NEW : Statistic page donation (#28463)
* v1 statistic page don

* add link

* fix phpstan

* fix

* fix

* Update index.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-01 21:17:52 +01:00
lamrani abdelwadoud
7b92c9912b Fix return type by adding string in select_comptes method (#28496)
* Fix return type by addin string in select_comptes method

* update return doc for method

* Update html.form.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-01 21:13:12 +01:00
lamrani abdelwadoud
dd7be6c932 Fix return type string instead of int (#28499)
* Fix return type string instead of int

* update doc method for return
2024-03-01 21:00:49 +01:00
Laurent Destailleur
6917b1046b Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-01 20:55:41 +01:00
Laurent Destailleur
19a22f6b6d Fix #28509 2024-03-01 20:55:31 +01:00
lamrani abdelwadoud
351ea07229 Fix return type when output is 1 (#28501)
* Fix return type when output is 1

* update doc method
2024-03-01 20:49:23 +01:00
Laurent Destailleur
7d2928fe1f Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-01 20:20:00 +01:00
Laurent Destailleur
4279478acd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-01 19:40:36 +01:00