* Fix: Typing for PDF parameter
# Fix: Typing for PDF parameter
Change PDF to known type.
* Fix: Typing for PDF parameter
# Fix: Typing for PDF parameter
Change PDF to known type.
# Fix: Reviewed, fixed and optimized dol_dir_list
Review: had some issues using the exclusion filter, may be unrelated to implementation.
Fixed: is_link was testing utf8 filename, not os filename version.
Optimized:
- Simplified is_dir branches
- Avoid computing the exclusion arrays multiple times
# Fix: Protect from negative array index access
Negative array index access can happen when $i is 0.
While this raises a notice before PHP7.1 it would compare to the last
value in the string so it's invalid.
Detected with phan: PhanCompatibleNegativeStringOffset
htdocs/compta/paiement/class/paiement.class.php 115 PHPDoc type array<int, float> of property Paiement::$multicurrency_tx is not covariant with PHPDoc type float of overridden property CommonObject::$multicurrency_tx.
htdocs/compta/paiement/class/paiement.class.php 120 PHPDoc type array<int, string> of property Paiement::$multicurrency_code is not covariant with PHPDoc type string of overridden property CommonObject::$multicurrency_code.
htdocs/commande/class/commande.class.php 538 Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/commande/class/commande.class.php 675 Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/compta/facture/class/facture.class.php 2859 Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php 3378 Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php 3696 Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/expedition/class/expedition.class.php 1245 Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php 1438 Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php 2326 Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/expedition/class/expedition.class.php 2487 Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/fourn/class/fournisseur.commande.class.php 1283 Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.commande.class.php 2278 Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php 1858 Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php 1999 Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/commande/dispatch.php 435 Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php 482 Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php 489 Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/reception/class/reception.class.php 582 Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php 1081 Property CommonObject::$origin (string) does not accept null.
htdocs/reception/class/reception.class.php 1674 Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php 1833 Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php 1967 Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/takepos/invoice.php 332 Property CommonObject::$origin (string) does not accept Facture.
htdocs/takepos/invoice.php 336 Property CommonObject::$origin (string) does not accept Facture.
* qual: phpstan for htdocs/compta/tva/class/paymentvat.class.php
htdocs/compta/tva/class/paymentvat.class.php 540 Property CommonObject::$tms (int) does not accept string.
* qual: phpstan - various "$enabled (int) does not accept bool."
htdocs/core/boxes/box_actions.php 54 Property box_actions::$enabled (int) does not accept bool.
htdocs/core/boxes/box_actions_future.php 54 Property box_actions_future::$enabled (int) does not accept bool.
htdocs/core/boxes/box_activity.php 53 Property box_activity::$enabled (int) does not accept string.
* qual: phpstan for htdocs/core/boxes/box_activity.php
htdocs/core/boxes/box_activity.php 53 Property box_activity::$enabled (int) does not accept string.
* qual: phpstan for htdocs/core/modules/modTakePos.class.php
htdocs/core/modules/modTakePos.class.php 284 Property Societe::$code_client (string) does not accept int.
htdocs/core/modules/modTakePos.class.php 285 Property Societe::$code_fournisseur (string) does not accept int.
